New issue
Advanced search Search tips

Issue 873377 link

Starred by 1 user
Status: Fixed
Owner:
vmi...@chromium.org
Closed: Sep 5
Cc:
sadrul@chromium.org
ericrk@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Viz on Android doesn't have a thread name VizCompositorThread in Tracing.

Project Member Reported by vmi...@chromium.org, Aug 10 
When capturing a trace on Android with '--enable-features=VizDisplayCompositor', the Viz thread doesn't have a name in the trace, which breaks some perf metrics computation.

I think the reason is JavaHandlerThread does not register a name with base::PlatformThread::SetName().
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29bb4ab60c65fce9b311562e77c2d8d87f233b76

commit 29bb4ab60c65fce9b311562e77c2d8d87f233b76
Author: Victor Miura <vmiura@chromium.org>
Date: Wed Aug 29 19:31:52 2018

Fix Java thread names on Android.

To get correct thread names in Chrome tracing, it's necessary to register
threads with the base::ThreadIdNameManager and set the thread name.

BUG= 873377 

Change-Id: Icb8d68f941f95f65c53ae19b16e05f0d85c9bfbd
Reviewed-on: https://chromium-review.googlesource.com/1192589
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587242}
[modify] https://crrev.com/29bb4ab60c65fce9b311562e77c2d8d87f233b76/base/android/java_handler_thread.cc
[modify] https://crrev.com/29bb4ab60c65fce9b311562e77c2d8d87f233b76/base/android/java_handler_thread.h
[modify] https://crrev.com/29bb4ab60c65fce9b311562e77c2d8d87f233b76/base/test/android/java_handler_thread_helpers.cc
[modify] https://crrev.com/29bb4ab60c65fce9b311562e77c2d8d87f233b76/content/browser/android/launcher_thread.cc

Comment 2 by vmi...@chromium.org, Sep 5

Status: Fixed (was: Started)
►

Sign in to add a comment