New issue
Advanced search Search tips

Issue 873343 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

dino game plays while off screen

Project Member Reported by harringtond@chromium.org, Aug 10

Issue description

Chrome Version: m68
OS: Linux (and others)

What steps will reproduce the problem?
(1) Disconnect from the internet
(2) Attempt to navigate to a page
(3) See the dino. Reduce the size of the window until it's scrollable. Scroll down. You can activate the dino page while it's off screen.
Some scrolling features no longer work until the dino runs into a cactus. 

What is the expected result?

The game is scrolled into view, or not activated while not fully in view.
 
Labels: OS-Android OS-Chrome OS-iOS OS-Linux OS-Mac OS-Windows
Status: Assigned (was: Untriaged)
Mostly affects desktop, since the space key is used to activate the game. Space would normally scroll the page down.

Possible solutions:
- Detect whether the dino game area is fully visible, if not then don't start the game.
- Only allow the game to start if there has been no scrolling. Potential annoyance if you scrolled a little.
- Remove the space key as an activation key. Up arrow is the alternative key and that doesn't suffer from the same problems.
- Override the space bar and always start the game, auto scrolling the game area in view.


Status: Started (was: Assigned)
In progress.
dino-prevent-activation-when-scrolled.mov
1.5 MB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24d8c445a5bb1cfbb0b27c89dbf5a8ac6314b69c

commit 24d8c445a5bb1cfbb0b27c89dbf5a8ac6314b69c
Author: Edward Jung <edwardjung@chromium.org>
Date: Tue Oct 02 13:42:14 2018

chrome://dino Ensure the game area is in view before activating

New content to the offline page will mean it's currently possible to
scroll down the page and inadverently activate the offline dino game.

This change ensures the game canvas is mostly  in the viewport before
allow the game to start.

Bug:  873343 
Change-Id: I04d874f71480b3aac20a24373466626e3372f246
Reviewed-on: https://chromium-review.googlesource.com/1240339
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Edward Jung <edwardjung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595822}
[modify] https://crrev.com/24d8c445a5bb1cfbb0b27c89dbf5a8ac6314b69c/components/neterror/resources/offline.js

Cc: vamshi.kommuri@chromium.org
Labels: Needs-Feedback
Tried checking the issue on latest canary 71.0.3569.0 using Mac 10.13.1 and Windows 10.
Our observations:
------------------
Observed on hitting space bar when dino is not on the screen, we noticed the game didn't start and while game in ON, browser didn't allow us to scroll down. Attaching the screen cast for reference.
Note: But the issue is still seen on Ubuntu 14.04 using version 71.0.3569.0 i.e., we are able to scroll while dine is moving.

@Edward Jung: Requesting you to help us by providing your inputs on OS Linux.

Thanks!
873343 CL.mp4
4.8 MB View Download
Status: Fixed (was: Started)
Thanks for checking. Chrome://dino takes you to the arcade mode which plays in full screen so that's why you can't scroll.

If you go to chrome://network-error/-106 that will give you the offline page that regular users see and you can scroll down. 


Even after navigating to chrome://network-error/-106 on Ubuntu 14.04 we were able to scroll while the dino is moving i.e., when game is being played. Able to verify the fix on 71.0.3569.0 using Mac 10.13.1 and Windows 10, but we couldn't verify the same on Ubuntu 14.04. Attaching the screencast of the same for reference. 

@Edward Jung: Requesting you to help us in verifying the fix on Linux.

Thanks!
873343.mp4
6.0 MB View Download
re #6: Linux behaviour, that's standard behaviour on desktop. The fix is to prevent you starting the game whilst the dino game canvas is off the screen, not during game play.

Sign in to add a comment