New issue
Advanced search Search tips

Issue 873342 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Make it clearer when an analyzer exceeds the max number of comments to send

Project Member Reported by qyears...@chromium.org, Aug 10

Issue description

Currently, if an analyzer produces more than 50 comments in a CL, the comments are not sent, but the analyzer is still marked as success and there's no clear indication of why the comments weren't sent.

One option: in gerrit/rpc_report_results.cc, when sending results, for analyzers that had too many results, send a single message instead saying "analyzer X produced too many comments"

Another option: Extract a "max comments" constant out to some common place, and use it in analyzers to abort or truncate analysis.
 

Sign in to add a comment