New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 873331 link

Starred by 1 user

Issue metadata

Status: Fixed
Last visit 15 days ago
Closed: Aug 14
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Sign in to add a comment

[📍] When pressing re-run button: "could not convert string to float: None"

Project Member Reported by, Aug 10

Issue description

I think this is related to  issue 873022 .

Previously, perf dashboard was kicking off jobs with comparison_magnitude set to the string 'None'. Now, that value is no longer valid. comparison_magnitude must be a float. So, re-kicking those old jobs will give an error.

Short term solution is to add a check somewhere in the form or backend that ignores comparison_magnitude == 'None'.
Project Member

Comment 1 by, Aug 10

The following revision refers to this bug:

commit 21cd5a309631b78d6deedc1ca56ca83ead9fbadd
Author: Dave Tu <>
Date: Fri Aug 10 22:50:54 2018

[pinpoint] Ignore comparison_magnitude == 'None' for reruns.

Perf dashboard has been sending jobs with comparison_magnitude == 'None'
(The string containing 'None'.) This is no longer permitted in the API.
This is a workaround that lets us re-run jobs with the invalid argument.

Bug:  chromium:873331 
Change-Id: I69ae79ec6317f86e9411f519856b294741d0115d
Reviewed-by: Annie Sullivan <>
Commit-Queue: David Tu <>


Project Member

Comment 2 by, Aug 11

The following revision refers to this bug:

commit 24be12346d5a4ec8ebcc2c0615add14d150496e7
Author: catapult-chromium-autoroll <>
Date: Sat Aug 11 00:34:54 2018

Roll src/third_party/catapult 5a4110982f31..21cd5a309631 (1 commits)

git log 5a4110982f31..21cd5a309631 --date=short --no-merges --format='%ad %ae %s'
2018-08-10 [pinpoint] Ignore comparison_magnitude == 'None' for reruns.

Created with:
  gclient setdep -r src/third_party/catapult@21cd5a309631

The AutoRoll server is located here:

Documentation for the AutoRoller is here:

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


BUG= chromium:873331

Change-Id: Ie322f1501b9f5411006fd4d603edf90941097a93
Reviewed-by: catapult-chromium-autoroll <>
Commit-Queue: catapult-chromium-autoroll <>
Cr-Commit-Position: refs/heads/master@{#582399}

Blocking: 873724
Status: Fixed (was: Assigned)
Blocking: -873724

Sign in to add a comment