floating keyboard fit & finish |
|||||||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win10, MacOS 10.12, etc...) What steps will reproduce the problem? (1) Get a floating keyboard (2) (3) What is the expected result? - the font treatment of "?123" is not aligned with design spec - emoji icon and dismiss keyboard icon size is not aligned with spec - blue ENTER button should be center aligned with backspace / shift / dismiss keyboard - handwriting mode - bottom right icons are squeezed together - dismiss keyboard icon is too large, margin to the blue enter icon is incorrect - has wrong border radius, please check with spec What happens instead? Please check with design spec Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Aug 10
,
Aug 14
,
Aug 14
Thank you @qqwangxin for the carefully review and feedback! 1. will fix. 2. will fix. 3. enter key takes extra width so is larger and unaligned, UX is looking for solution. 4. will fix. 5. won't have this radius to align with android, will update spec.
,
Aug 16
No problem, ping me anytime if you have questions.
,
Aug 17
fixed in google3, will do a release soon with some other fixes.
,
Aug 28
,
Aug 28
,
Aug 29
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/02d5da2ab215ae700542eeb0a613fa91cd75303c commit 02d5da2ab215ae700542eeb0a613fa91cd75303c Author: Darren Shen <shend@google.com> Date: Wed Aug 29 18:16:14 2018
,
Sep 6
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by qqwangxin@chromium.org
, Aug 10