New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 873317 link

Starred by 1 user
Status: Fixed
Owner:
█ alexclarke@chromium.org
Last visit > 30 days ago
Closed: Aug 17
Cc:
haraken@chromium.org
altimin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Document WebScopedVirtualTimePauser

Project Member Reported by dcheng@chromium.org, Aug 10 
I came across this class while doing another review. I searched around and couldn't really find any documentation: the class-level comment just says what the class does, but it's not obvious (to me) when or why it's important to pause virtual time, nor how to choose between instant and non-instant.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/409b9c00941963df196bd1356893d2e777ae4e44

commit 409b9c00941963df196bd1356893d2e777ae4e44
Author: Alex Clarke <alexclarke@chromium.org>
Date: Fri Aug 17 08:37:26 2018

Better documentation for WebScopedVirtualTimePauser

Updates the documentation as requested.

Bug:  873317 
Change-Id: Id1deb86475f93896935e7962350af7033b0246e9
TBR: pfeldman@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1177397
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583992}
[modify] https://crrev.com/409b9c00941963df196bd1356893d2e777ae4e44/third_party/blink/public/platform/web_scoped_virtual_time_pauser.h

Comment 2 by alexclarke@chromium.org, Aug 17

Status: Fixed (was: Assigned)
►

Sign in to add a comment