New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 873316 link

Starred by 1 user
Status: Fixed
Owner:
csharrison@chromium.org
Closed: Sep 20
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Expand UKM to allow linking between sources

Project Member Reported by csharrison@chromium.org, Aug 10 
See doc for concrete proposal:
https://docs.google.com/document/d/1C_bXDVhixR0DzJMKwa9aniXXHX04izx-NoeD71VSq5o/edit?usp=sharing

I propose we add:
1. Tab id: unique per session id which identifies the tab the page load occurred in

2. Previous source id: the previous source id in the tab the page load occurred in

3. Opener source id: The source id of the page load which opened this tab / window
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef958bff87330de90698ac651e4a82ca8c7a1855

commit ef958bff87330de90698ac651e4a82ca8c7a1855
Author: Charlie Harrison <csharrison@chromium.org>
Date: Mon Aug 20 14:49:02 2018

Move ukm_source to //services/metrics/public

This is in preparation to add a struct UkmSource::Metadata, which would need to be used
in //services.

TBR=sky@chromium.org

Bug:  873316 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0d33f6ece24b9176ff86310ef2e7347453b5ccfa
Reviewed-on: https://chromium-review.googlesource.com/1179992
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584441}
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/android/feature_utilities.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/autofill/autofill_metrics_browsertest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/chromeos/power/ml/user_activity_manager_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/media/autoplay_metrics_browsertest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/media/media_engagement_contents_observer_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/metrics/oom/out_of_memory_reporter_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/metrics/ukm_browsertest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/observers/local_network_requests_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.h
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/observers/offline_page_previews_page_load_metrics_observer.h
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.h
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.h
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/observers/previews_ukm_observer.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/observers/previews_ukm_observer_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/observers/scheme_page_load_metrics_observer.h
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/observers/security_state_page_load_metrics_observer_browsertest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/page_load_metrics/page_load_tracker.h
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/password_manager/save_password_infobar_delegate_android_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/resource_coordinator/tab_activity_watcher_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/ui/blocked_content/popup_opener_tab_helper_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/ui/tabs/tab_ukm_test_helper.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/chrome/browser/ui/views/payments/payment_request_journey_logger_browsertest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/components/autofill/core/browser/credit_card_save_manager_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/components/password_manager/core/browser/password_manager_metrics_recorder_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/components/password_manager/core/browser/password_manager_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/components/payments/core/journey_logger_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/components/translate/core/browser/translate_ranker_impl_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/components/ukm/BUILD.gn
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/components/ukm/content/app_source_url_recorder_test.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/components/ukm/content/source_url_recorder_browsertest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/components/ukm/content/source_url_recorder_test.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/components/ukm/debug/ukm_debug_data_extractor.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/components/ukm/test_ukm_recorder.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/components/ukm/ukm_recorder_impl.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/components/ukm/ukm_service_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/content/browser/plugin_service_impl_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/ios/chrome/browser/metrics/ukm_url_recorder_unittest.mm
[modify] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/services/metrics/public/cpp/BUILD.gn
[add] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/services/metrics/public/cpp/DEPS
[rename] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/services/metrics/public/cpp/ukm_source.cc
[rename] https://crrev.com/ef958bff87330de90698ac651e4a82ca8c7a1855/services/metrics/public/cpp/ukm_source.h
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfeaee7f910cdd5a5dd5dc0a1a0805ad361918d3

commit dfeaee7f910cdd5a5dd5dc0a1a0805ad361918d3
Author: Charlie Harrison <csharrison@chromium.org>
Date: Fri Aug 24 13:50:06 2018

Add tab_id/previous_source_id/opener_source_id to UkmSource

This CL adds three new fields to UkmSource. A follow-up will propagate
changes to the underlying proto fields.

Bug:  873316 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic691221c8165df7cee16b089407d8ddd346e78c3
Reviewed-on: https://chromium-review.googlesource.com/1175033
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585824}
[modify] https://crrev.com/dfeaee7f910cdd5a5dd5dc0a1a0805ad361918d3/chrome/browser/metrics/ukm_browsertest.cc
[modify] https://crrev.com/dfeaee7f910cdd5a5dd5dc0a1a0805ad361918d3/components/ukm/content/source_url_recorder.cc
[modify] https://crrev.com/dfeaee7f910cdd5a5dd5dc0a1a0805ad361918d3/components/ukm/ukm_recorder_impl.cc
[modify] https://crrev.com/dfeaee7f910cdd5a5dd5dc0a1a0805ad361918d3/components/ukm/ukm_recorder_impl.h
[modify] https://crrev.com/dfeaee7f910cdd5a5dd5dc0a1a0805ad361918d3/components/ukm/ukm_service_unittest.cc
[modify] https://crrev.com/dfeaee7f910cdd5a5dd5dc0a1a0805ad361918d3/ios/chrome/browser/metrics/ukm_url_recorder.mm
[modify] https://crrev.com/dfeaee7f910cdd5a5dd5dc0a1a0805ad361918d3/services/metrics/public/cpp/delegating_ukm_recorder.cc
[modify] https://crrev.com/dfeaee7f910cdd5a5dd5dc0a1a0805ad361918d3/services/metrics/public/cpp/delegating_ukm_recorder.h
[modify] https://crrev.com/dfeaee7f910cdd5a5dd5dc0a1a0805ad361918d3/services/metrics/public/cpp/mojo_ukm_recorder.cc
[modify] https://crrev.com/dfeaee7f910cdd5a5dd5dc0a1a0805ad361918d3/services/metrics/public/cpp/mojo_ukm_recorder.h
[modify] https://crrev.com/dfeaee7f910cdd5a5dd5dc0a1a0805ad361918d3/services/metrics/public/cpp/ukm_recorder.h
[modify] https://crrev.com/dfeaee7f910cdd5a5dd5dc0a1a0805ad361918d3/services/metrics/public/cpp/ukm_source.cc
[modify] https://crrev.com/dfeaee7f910cdd5a5dd5dc0a1a0805ad361918d3/services/metrics/public/cpp/ukm_source.h
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39a7befde4b73598cb387997acfd36249953ed64

commit 39a7befde4b73598cb387997acfd36249953ed64
Author: Charlie Harrison <csharrison@chromium.org>
Date: Mon Aug 27 16:06:42 2018

Update third_party/metrics_proto

Bug:  873316 
Change-Id: Ifddbd91938e0bede3e68fc681009bafcd69e5882
Reviewed-on: https://chromium-review.googlesource.com/1188843
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586274}
[modify] https://crrev.com/39a7befde4b73598cb387997acfd36249953ed64/third_party/metrics_proto/README.chromium
[modify] https://crrev.com/39a7befde4b73598cb387997acfd36249953ed64/third_party/metrics_proto/ukm/source.proto
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72782fca484d7352f2e8a61a0d804b4bd3c8207a

commit 72782fca484d7352f2e8a61a0d804b4bd3c8207a
Author: Charlie Harrison <csharrison@chromium.org>
Date: Mon Aug 27 19:58:29 2018

Set UKM proto sources for linking sources

Bug:  873316 
Change-Id: I2d034ad8e7e272b487741eaa40f5318185caff6c
Reviewed-on: https://chromium-review.googlesource.com/1190664
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586379}
[modify] https://crrev.com/72782fca484d7352f2e8a61a0d804b4bd3c8207a/services/metrics/public/cpp/ukm_source.cc

Comment 5 by csharrison@chromium.org, Sep 20

Status: Fixed (was: Assigned)
►

Sign in to add a comment