New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 873310 link

Starred by 1 user
Status: Fixed
Owner:
hansberry@chromium.org
Closed: Oct 11
Cc:
█ jlklein@chromium.org
shibasheikh@chromium.org
jessejames@chromium.org
khorimoto@chromium.org
█ jordynass@chromium.org
█ jhawkins@chromium.org
hansberry@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 870130

Participants' hotlists:
Better-Together-Launch-Blockers


Sign in to add a comment

Smart lock notification post setup should deep link to SmartLock settings inside Better together settings

Project Member Reported by shibasheikh@chromium.org, Aug 10 
Current behaviour:
Takes users to the Screen lock page

Expected behaviour:
Should take users to the Better together settings page

Comment 1 by jlklein@chromium.org, Aug 10

Cc: jordynass@chromium.org jlklein@chromium.org hansberry@chromium.org
Labels: OS-Chrome
Owner: khorimoto@chromium.org

Comment 2 by khorimoto@chromium.org, Aug 10

Cc: jessejames@chromium.org khorimoto@chromium.org shibasheikh@chromium.org jhawkins@chromium.org
Owner: shibasheikh@chromium.org
Should there be any changes to the notification besides the click handler?

Comment 3 by jlklein@chromium.org, Aug 16

Labels: Pri-2

Comment 4 by shibasheikh@chromium.org, Aug 27 

Nope

Comment 5 by khorimoto@chromium.org, Aug 28

Owner: ----
Status: Available (was: Untriaged)

Comment 6 by khorimoto@chromium.org, Aug 29

Labels: -Restrict-View-Google

Comment 7 by jlklein@chromium.org, Sep 6

Owner: jhawkins@chromium.org
Status: Assigned (was: Available)

Comment 8 by khorimoto@chromium.org, Sep 11

Labels: -M-70 M-71

Comment 9 by jlklein@chromium.org, Sep 20

Components: -UI>ProximityAuth UI>Multidevice

Comment 10 by jlklein@chromium.org, Oct 1

Summary: Smart lock notification post setup should deep link to SmartLock settings inside Better together settings (was: Smart lock notification post setup should deep link to Better together settings)

Comment 11 by hansberry@chromium.org, Oct 3

Blockedon: 870130

Comment 12 by hansberry@chromium.org, Oct 11

Owner: hansberry@chromium.org
Status: Started (was: Assigned)
Grabbing.
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e00e8b8d4c51801196e8782746144bd487b8c4ae

commit e00e8b8d4c51801196e8782746144bd487b8c4ae
Author: Ryan Hansberry <hansberry@chromium.org>
Date: Thu Oct 11 20:42:56 2018

Smart Lock: Deep link 'Chromebook added' notification to new settings page

R=jhawkins@chromium.org

TBR=jhawkins@chromium.org

Bug:  873310 
Change-Id: Ie0e9a8ef43c890666b39e4f188d9ba156295c7e8
Reviewed-on: https://chromium-review.googlesource.com/c/1277866
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598919}
[modify] https://crrev.com/e00e8b8d4c51801196e8782746144bd487b8c4ae/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller.cc

Comment 14 by hansberry@chromium.org, Oct 11

Status: Fixed (was: Started)
►

Sign in to add a comment