New issue
Advanced search Search tips

Issue 873296 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

isolate.py: remove config variables

Project Member Reported by erikc...@chromium.org, Aug 10

Issue description

isolate.py saves state to desk as a cache for the next run. Supposedly, the presence of the cache should not affect final results.

However, it looks like some state is carried over. e.g. config_variables are added to the current run from the cache:
https://cs.chromium.org/chromium/infra/luci/client/isolate.py?type=cs&q=isolate.py&sq=package:chromium&g=0&l=501

I haven't been able to test this because of this bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=873295

maruel@ states that this was left-over from GYP support and should be removed.
 
Components: -Infra>Platform Infra>Platform>Swarming
maruel@ is this something chromium specific, or is this project-independent cleanup of isolate.py tool?
Status: Available (was: Untriaged)
It's generic.

--config-variable, --path-variable, --extra-variable (and --ignore_broken_items) are not used since we switched from GYP to GN.

Sign in to add a comment