Overview doesn't respond to pending split with dragged tab |
||
Issue descriptionChrome OS Version: 70.0.3511.0 When dragging an overview window to a side to split, the other overview windows respond by moving to the other side in anticipation of the snap. Dragged tabs should have the same effect, but don't currently. See video comparing the two cases: https://drive.google.com/open?id=10syHXML-Br8kaVubInNm7mpOjo-h81cB
,
Aug 14
See a recorded video that reposition the overview windows with the new selector item: https://drive.google.com/open?id=1koXqSVuf58CpBQZvKrRVhL5zZrJCN-xm Ben, does it look good to you?
,
Aug 14
Really good question. I know it makes it more complicated, but I think we should take the opportunity to hide the indicator when the split side preview area is entered. It should re-appear if the user moves back to the center to cancel split. This way, there's no further animation when the user lets go.
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcab234783a396391ce97a62ec6c8849ebb8d01f commit fcab234783a396391ce97a62ec6c8849ebb8d01f Author: Xiaoqian Dai <xdai@chromium.org> Date: Thu Aug 16 17:02:03 2018 When dragging a window around overview, reposition overview windows. When dragging a window from caption area in tablet mode, overview will open behind the dragged windows. When the dragged window is dragged into the preview split area, we should update the overview grid's bounds and also update the new selector item's visibility. See recorded video: https://drive.google.com/open?id=10gPVG1Wlgt4YDnZI_tPS2p6JJGYJ-ztl Bug: 873292 Change-Id: Ibc7028820bed11d61bdbb376fdc6723c26a0c262 Reviewed-on: https://chromium-review.googlesource.com/1176220 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#583696} [modify] https://crrev.com/fcab234783a396391ce97a62ec6c8849ebb8d01f/ash/wm/overview/overview_utils.h [modify] https://crrev.com/fcab234783a396391ce97a62ec6c8849ebb8d01f/ash/wm/overview/window_grid.cc [modify] https://crrev.com/fcab234783a396391ce97a62ec6c8849ebb8d01f/ash/wm/overview/window_grid.h [modify] https://crrev.com/fcab234783a396391ce97a62ec6c8849ebb8d01f/ash/wm/splitview/split_view_controller_unittest.cc [modify] https://crrev.com/fcab234783a396391ce97a62ec6c8849ebb8d01f/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.cc
,
Aug 16
|
||
►
Sign in to add a comment |
||
Comment 1 by x...@chromium.org
, Aug 14