org.chromium.distiller.EmbedExtractorTest.testFigureCaptionWithAnchor fails |
||
Issue descriptionWhen running DOM distiller tests with https://chromium-review.googlesource.com/c/chromium/src/+/1114673 (with convert_brs_to_newlines set to false), EmbedExtractorTest.testFigureCaptionWithAnchor fails. Expected: "This is a caption\nlink" Actual : "This is a captionlink" This only affects generateOutput(textOnly=true), and it is only used in testing and evaluation. Root cause: In the test, the extracted figure element is not rendered, so the innerText behaves different. We should render it before calling innerText.
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/dom-distiller/+/8c9af2c1eea12397e0b4ce3c64369524b6433fca commit 8c9af2c1eea12397e0b4ce3c64369524b6433fca Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Fri Aug 10 21:13:15 2018 Make generateOutput(textOnly=true) standard compliant When getting innerText in tests and quality evaluation, make sure the node is rendered, so that the line breaks are correctly generated. This fixes https://github.com/chromium/dom-distiller/issues/10 Bug: 859410 , 873291 Change-Id: Ic9c3469b3e79b49438e4a35460612a337b2dfaab Reviewed-on: https://chromium-review.googlesource.com/1171585 Reviewed-by: Matthew Jones <mdjones@chromium.org> [modify] https://crrev.com/8c9af2c1eea12397e0b4ce3c64369524b6433fca/java/org/chromium/distiller/DomUtil.java [modify] https://crrev.com/8c9af2c1eea12397e0b4ce3c64369524b6433fca/java/org/chromium/distiller/webdocument/WebText.java [modify] https://crrev.com/8c9af2c1eea12397e0b4ce3c64369524b6433fca/java/org/chromium/distiller/webdocument/WebTable.java [modify] https://crrev.com/8c9af2c1eea12397e0b4ce3c64369524b6433fca/java/org/chromium/distiller/webdocument/WebFigure.java
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81db97a9a7f000ed4133a9891781658945853ae3 commit 81db97a9a7f000ed4133a9891781658945853ae3 Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Tue Aug 14 00:10:11 2018 Roll DOM Distiller JavaScript distribution package Diff since last roll: https://chromium.googlesource.com/chromium/dom-distiller/+/9596033e36..ccfe233400 Picked up changes: https://chromium.googlesource.com/chromium/dom-distiller/+log/9596033e36..ccfe233400 ccfe233 Fix EmbedExtractorTest.testDivCaption 8825eaf In tests, render elements before getting their innerText 8c9af2c Make generateOutput(textOnly=true) standard compliant Bug: 651764 , 859410 , 873291 , 873298 Change-Id: I66bf2c9a433751597fc4c7153ce5955e28dad064 Reviewed-on: https://chromium-review.googlesource.com/1171847 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582763} [modify] https://crrev.com/81db97a9a7f000ed4133a9891781658945853ae3/DEPS [modify] https://crrev.com/81db97a9a7f000ed4133a9891781658945853ae3/third_party/dom_distiller_js/README.chromium
,
Aug 14
|
||
►
Sign in to add a comment |
||
Comment 1 by wychen@chromium.org
, Aug 10