Dragged tabs dropped in overview need bounds change |
|||
Issue descriptionChrome OS Version: 70.0.3511.0 When a tab is dragged and dropped in overview to create a new window, it should have its bounds updated on drop so that the overview thumbnail matches the size it will be when tapped. See end of video: https://drive.google.com/open?id=10u-a6jvEKXky0gWlpx8bC1zqDb0CeTA2
,
Aug 15
Hey Daisy, sorry, the example in the video is not super clear. Here's a more illustrative photo: https://drive.google.com/file/d/1-0LzsIeLj8hTP4Nf5KGh9BhUiR4dIXXz/view?usp=sharing The bug is about 1). When there are other fullscreen browser windows in overview as thumbnails, the contrast in size of the top bar between the dragged (and now dropped) tab versus the other windows is quite noticeable. Currently the bounds of the dragged tab window change to fullscreen once it's tapped on. If possible, it would be great if we could change those bounds on drop instead.
,
Aug 15
Now I get it. Thank you!
,
Aug 17
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/017cad775d7affe80efb2113bc0c7a00d7114bc6 commit 017cad775d7affe80efb2113bc0c7a00d7114bc6 Author: Xiaoqian Dai <xdai@chromium.org> Date: Tue Aug 21 18:10:07 2018 Tab dragging: Update the dragged window's bounds before adding to overview. Before the dragged window is added to overview, its bounds might needs to update as the dragged window's bounds might have changed during dragging and as a result its transform might be different with other window's transform in overview. Bug: 873284 Change-Id: I1257f8d4526b62bcf6d3174f611bc4d576818755 Reviewed-on: https://chromium-review.googlesource.com/1180376 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Mitsuru Oshima (Slow) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#584821} [modify] https://crrev.com/017cad775d7affe80efb2113bc0c7a00d7114bc6/ash/wm/overview/window_grid.cc [modify] https://crrev.com/017cad775d7affe80efb2113bc0c7a00d7114bc6/ash/wm/splitview/split_view_controller_unittest.cc
,
Aug 21
|
|||
►
Sign in to add a comment |
|||
Comment 1 by x...@chromium.org
, Aug 15