New issue
Advanced search Search tips

Issue 873275 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Participants' hotlists:
Gesture-polish


Sign in to add a comment

Dragging tab to top of splitscreen indicator cancels split

Project Member Reported by mccanny@chromium.org, Aug 10

Issue description

Chrome OS Version: 70.0.3511.0

Unlike dragging an overview window, dragging a tab to the top of the splitscreen indicator cancels the split.

Moving horizontally back beyond the splitscreen threshold should be the only way to cancel a split.

See video:
https://drive.google.com/open?id=10u-a6jvEKXky0gWlpx8bC1zqDb0CeTA2
 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f682e887207fb31675949f2f468a3d3072f1dcad

commit f682e887207fb31675949f2f468a3d3072f1dcad
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Tue Aug 14 21:28:39 2018

Tab dragging: do not cancel split when moving toward the top of the screen.

After drag starts, the window needs to be dragged vertically a small
amount of distance to be considered as 'moved' and only after that, the
drag indicators will show up and the window can be snapped. But after
the window has been 'moved', it should stay moved even the window is
dragged toward to the top of the screen.

Bug:  873275 
Change-Id: I4546a3a6839427c7232dcc5b6f234913b9dd516d
Reviewed-on: https://chromium-review.googlesource.com/1173472
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583041}
[modify] https://crrev.com/f682e887207fb31675949f2f468a3d3072f1dcad/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.cc
[modify] https://crrev.com/f682e887207fb31675949f2f468a3d3072f1dcad/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.h

Status: Fixed (was: Started)

Sign in to add a comment