New issue
Advanced search Search tips

Issue 873274 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature
Proj-XR

Blocking:
issue 819448
issue 845265



Sign in to add a comment

Support multiple controllers in VR UI

Project Member Reported by bajones@chromium.org, Aug 10

Issue description

VRShell should display as many controllers as the underlying platform supports. For example: Windows headsets commonly support two controllers, so VRShell should provide visual representations of both of them.
 
Blocking: 819448
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e4b5ecb72f6bb2c9b7c02226e0e5b9e2b53e302

commit 6e4b5ecb72f6bb2c9b7c02226e0e5b9e2b53e302
Author: Brandon Jones <bajones@chromium.org>
Date: Fri Nov 30 20:57:37 2018

Support display of multiple controllers in VRShell

Updates the VR UI model to allow an array of controllers, each of which
will be rendered as part of the UI. This update introduces a concept of
a "primary controller" (largely for porting convenience) that is
currently always the controller at index 0 of the array. We may want to
improve the logic around that in future CLs.

Bug: 873274
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I1a91f6550f4d051d35d872118c822f1b6716c614
Reviewed-on: https://chromium-review.googlesource.com/c/1171519
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612778}
[modify] https://crrev.com/6e4b5ecb72f6bb2c9b7c02226e0e5b9e2b53e302/chrome/browser/vr/browser_renderer.cc
[modify] https://crrev.com/6e4b5ecb72f6bb2c9b7c02226e0e5b9e2b53e302/chrome/browser/vr/browser_renderer_unittest.cc
[modify] https://crrev.com/6e4b5ecb72f6bb2c9b7c02226e0e5b9e2b53e302/chrome/browser/vr/elements/laser.cc
[modify] https://crrev.com/6e4b5ecb72f6bb2c9b7c02226e0e5b9e2b53e302/chrome/browser/vr/model/model.cc
[modify] https://crrev.com/6e4b5ecb72f6bb2c9b7c02226e0e5b9e2b53e302/chrome/browser/vr/model/model.h
[modify] https://crrev.com/6e4b5ecb72f6bb2c9b7c02226e0e5b9e2b53e302/chrome/browser/vr/test/ui_pixel_test.cc
[modify] https://crrev.com/6e4b5ecb72f6bb2c9b7c02226e0e5b9e2b53e302/chrome/browser/vr/test/ui_test.cc
[modify] https://crrev.com/6e4b5ecb72f6bb2c9b7c02226e0e5b9e2b53e302/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/6e4b5ecb72f6bb2c9b7c02226e0e5b9e2b53e302/chrome/browser/vr/ui.cc
[modify] https://crrev.com/6e4b5ecb72f6bb2c9b7c02226e0e5b9e2b53e302/chrome/browser/vr/ui.h
[modify] https://crrev.com/6e4b5ecb72f6bb2c9b7c02226e0e5b9e2b53e302/chrome/browser/vr/ui_input_manager_unittest.cc
[modify] https://crrev.com/6e4b5ecb72f6bb2c9b7c02226e0e5b9e2b53e302/chrome/browser/vr/ui_interface.h
[modify] https://crrev.com/6e4b5ecb72f6bb2c9b7c02226e0e5b9e2b53e302/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/6e4b5ecb72f6bb2c9b7c02226e0e5b9e2b53e302/chrome/browser/vr/ui_scene_creator.h
[modify] https://crrev.com/6e4b5ecb72f6bb2c9b7c02226e0e5b9e2b53e302/chrome/browser/vr/ui_unittest.cc

Blocking: 910748
Blocking: -910748 845265
Components: -UI>Browser>VR Blink>WebXR
Labels: -Type-Bug Type-Feature

Sign in to add a comment