New issue
Advanced search Search tips

Issue 873269 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug
Proj-Servicification



Sign in to add a comment

NavigationURLLoaderImpl::OnComplete handles net::OK

Project Member Reported by mmenke@chromium.org, Aug 10

Issue description

NavigationURLLoaderImpl::OnComplete has code to handle a status of net::OK.  The NetworkService itself will never call URLLoader::OnComplete with net::OK without calling OnReceiveResponse.

I think we should remove the net::OK logic from that function, and DCHECK instead (And possibly do something reasonable, just from a security standpoint, like show an error page, instead of treating it as a success).  If some other URLLoaderFactory implementations can send net::OK without calling OnReceiveResponse first, we should fix them.
 
Labels: Hotlist-KnownIssue OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Labels: android-fe-triaged
Status: Available (was: Untriaged)

Comment 3 Deleted

I'll take a look at this issue if no one works on it!

Sign in to add a comment