New issue
Advanced search Search tips

Issue 873266 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Collapse WindowCycleEventFilter and WindowCycleEventFilterClassic

Project Member Reported by jamescook@chromium.org, Aug 10

Issue description

Cleanup from ws2 / deprecation of ash::Confg::MASH

 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0021ce28165f8adb1f6f1f915ac818fd75e1b7ad

commit 0021ce28165f8adb1f6f1f915ac818fd75e1b7ad
Author: James Cook <jamescook@chromium.org>
Date: Mon Aug 13 03:37:25 2018

Collapse ash::WindowCycleEventFilter with WindowCycleEventFilterClassic

There's no separate "classic" mode in ash anymore. Collapse the
superclass with its only subclass.

Just cleanup, no functional changes.

Bug:  873266 
Test: ash_unittests
Change-Id: I70cdf56a8cb534cc5f5f1385ef5d702d3694b5a5
Reviewed-on: https://chromium-review.googlesource.com/1171821
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582499}
[modify] https://crrev.com/0021ce28165f8adb1f6f1f915ac818fd75e1b7ad/ash/BUILD.gn
[modify] https://crrev.com/0021ce28165f8adb1f6f1f915ac818fd75e1b7ad/ash/wm/window_cycle_controller.cc
[rename] https://crrev.com/0021ce28165f8adb1f6f1f915ac818fd75e1b7ad/ash/wm/window_cycle_event_filter.cc
[modify] https://crrev.com/0021ce28165f8adb1f6f1f915ac818fd75e1b7ad/ash/wm/window_cycle_event_filter.h
[delete] https://crrev.com/17e044d3ebd808102a1e23b610c812482265976e/ash/wm/window_cycle_event_filter_classic.h

Status: Fixed (was: Started)

Sign in to add a comment