New issue
Advanced search Search tips

Issue 873239 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Sep 25
Cc:
jbanavatu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Saved Passwords settings missing touch highlighting

Reported by smacc...@amazon.com, Aug 10 
Steps to reproduce the problem:
1. Save a password
2. Open Settings
3. Click on Passwords 
4. Click on any already saved password

What is the expected behavior?
Expected highlighting to indicate what you have selected.

What went wrong?
Cannot see what is highlighted.

Implications:
- Can't see highlighting when target is touched.
- Cannot see accessibility highlighting when exploring by touch.
- Can't see where you are when navigating with Bluetooth keyboard.

Did this work before? No 

Chrome version: 68.0.3440.84  Channel: n/a
OS Version: 
Flash Version: 

Implications:
- Can't see highlighting when target is touched.
- Cannot see accessibility highlighting when exploring by touch.
- Can't see where you are when navigating with Bluetooth keyboard.

Comment 1 by smacc...@amazon.com, Aug 10 

Attached screenshot with last button select via Bluetooth keyboard:
- without-button-highlighting.png (currently what happens).
- with-button-highlighting.png (proposed changed).
without-button-highlighting.png
52.7 KB View Download
with-button-highlighting.png
54.8 KB View Download

Comment 3 by chelamcherla@chromium.org, Aug 13

Labels: Needs-triage-Mobile
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4320b10ca553b0f4f0eb520aa7d967df0d8c775

commit c4320b10ca553b0f4f0eb520aa7d967df0d8c775
Author: Simon La Macchia <smacchia@amazon.com>
Date: Tue Aug 21 16:29:36 2018

Add button highlighting to saved passwords settings

Problem: Cannot see highlighting of currently selected Saved Password
when navigating Saved Password Settings for the following scenarios:
- with Bluetooth keyboard
- Accessibility (Explore by touch).
- Touch/click event highlighting.

Solution: Change background of affected buttons to
selectableItemBackground. This enables visible highlighting for the
above scenarios. See bug for screenshots.

Note: Also fixed presubmit errors for textAppearance.

R=melandory@chromium.org

Bug:  873239 
Change-Id: I0422529308c7898afc6a315a8369082b8db7af99
Reviewed-on: https://chromium-review.googlesource.com/1171115
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584776}
[modify] https://crrev.com/c4320b10ca553b0f4f0eb520aa7d967df0d8c775/chrome/android/java/res/layout/password_entry_editor_copyable_row.xml
[modify] https://crrev.com/c4320b10ca553b0f4f0eb520aa7d967df0d8c775/chrome/android/java/res/layout/password_entry_editor_interactive.xml

Comment 5 by smacc...@amazon.com, Aug 21 

Proposed fix was accepted. This can be marked as fixed and closed.

Comment 6 by jbanavatu@chromium.org, Sep 25

Cc: jbanavatu@chromium.org
Labels: Triaged-Mobile
Status: Fixed (was: Unconfirmed)
As per c#5,marking this as Fixed.

Thanks!
►

Sign in to add a comment