there seems to be a problem with uploading updates for draft patches |
||||
Issue descriptionI am working with a stack of two patches: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1171200 https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1171201 I first uploaded them using 'repo upload ... -d', then I edited the patches and tried uploading the new set using the same 'repo upload ... -d' command. At this point the new version did not show up on the server, in the box where diff sides can be picked option 'edit' showed up, but when trying to see diffs it would show the single source, not diffs. then I tried to run 'repo upload ...' (without -d) - at this point the command line reported that patches got updated, but I don't see the second patchset when looking on the server. But when I try removing these patches from the server, it refuses to remove, reporting that newer versions are available. Not sure if I am missing something, will leave these two patches alone in case someone wants to investigate.
,
Aug 10
Bumping this over to Chromium for triage. We on Gerrit don't maintain the repo CLI, but if there's a Gerrit bug here I can definitely help,
,
Nov 19
this is fallout from disabling support for Private CLs in chromium GoB instances. draft CLs are no longer a thing, so they're converted to private CLs instead. the latest repo (not released) has explicit --private & --wip flags.
,
Nov 19
,
Nov 19
and cherry picks for these features have been prepared back in October and could be merged into chrome os repo any time: https://chromium-review.googlesource.com/c/external/repo/+/1309161 https://chromium-review.googlesource.com/c/external/repo/+/1318281 https://chromium-review.googlesource.com/c/external/repo/+/1318282 Mike, is there a reason not to merge this? |
||||
►
Sign in to add a comment |
||||
Comment 1 by kaspern@google.com
, Aug 10