New issue
Advanced search Search tips

Issue 873217 link

Starred by 1 user
Status: Assigned
Owner:
jinsuk...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task
Proj-VR
Proj-XR



Sign in to add a comment

Move test-only JNI RenderFrameHost code

Project Member Reported by bsheedy@chromium.org, Aug 10 
https://chromium-review.googlesource.com/c/chromium/src/+/1163831 added the ability to call RenderFrameHost::ExecuteJavaScriptForTests from Java. This should be moved out of the regular RenderFrameHostAndroid class into some test-only version that's not included in production builds.

Comment 1 by bsheedy@chromium.org, Aug 10

Owner: jinsuk...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to jinsukkim@ at the suggestion of boliu@ during the review.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eda860057b3f9a54dce4c3dddafaf9d4231f9502

commit eda860057b3f9a54dce4c3dddafaf9d4231f9502
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Mon Sep 03 06:45:49 2018

Android: Deletes test-only API from WebContents

Moves |WebContents.simulateRendererKilledForTesting| to a test-only class.

Bug: 873217
Change-Id: Ice84e5f4b7eb5ccc9eb852bc2957b7392b8eca92
Reviewed-on: https://chromium-review.googlesource.com/1198668
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588339}
[modify] https://crrev.com/eda860057b3f9a54dce4c3dddafaf9d4231f9502/chrome/android/javatests/src/org/chromium/chrome/browser/WarmupManagerTest.java
[modify] https://crrev.com/eda860057b3f9a54dce4c3dddafaf9d4231f9502/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/eda860057b3f9a54dce4c3dddafaf9d4231f9502/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java
[modify] https://crrev.com/eda860057b3f9a54dce4c3dddafaf9d4231f9502/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/PictureInPictureControllerTest.java
[modify] https://crrev.com/eda860057b3f9a54dce4c3dddafaf9d4231f9502/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
[modify] https://crrev.com/eda860057b3f9a54dce4c3dddafaf9d4231f9502/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
[modify] https://crrev.com/eda860057b3f9a54dce4c3dddafaf9d4231f9502/content/public/test/android/javatests/src/org/chromium/content_public/browser/test/mock/MockWebContents.java
[modify] https://crrev.com/eda860057b3f9a54dce4c3dddafaf9d4231f9502/content/public/test/android/javatests/src/org/chromium/content_public/browser/test/util/WebContentsUtils.java
►

Sign in to add a comment