Unify settings strings for Autofill on all platforms |
|||
Issue descriptionCurrently, each platform has their own string. They should be the same everywhere insteads. Step1: Move the desktop strings from settings_strings.grdp to autofill_strings.grd Step2: Make android use those strings. (Currently in android_chrome_strings.grd) Step3: Make iOS use those strings. (Currently in ios_strings.grd)
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f471e842b41f2c987fd9b680c5b911625aabb384 commit f471e842b41f2c987fd9b680c5b911625aabb384 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Mon Aug 13 21:20:37 2018 [AF] Unify Autofill settings strings on all platforms (part 1) Takes Autofill Settings strings related to the new address and credit card toggles to components/autofill_strings.grpd to share on all platforms. Bug: 873215 Change-Id: I358455a33734650dceed1196385d5262efa5b90a Reviewed-on: https://chromium-review.googlesource.com/1171560 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582706} [modify] https://crrev.com/f471e842b41f2c987fd9b680c5b911625aabb384/chrome/app/settings_strings.grdp [modify] https://crrev.com/f471e842b41f2c987fd9b680c5b911625aabb384/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/f471e842b41f2c987fd9b680c5b911625aabb384/components/autofill_strings.grdp
,
Aug 14
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e7b930c6f183906f801a0ccbd26c539a2d0cb53 commit 2e7b930c6f183906f801a0ccbd26c539a2d0cb53 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Wed Aug 22 23:49:53 2018 [AF][IOS] Unify Autofill settings strings on all platforms (part 2) - Updates existing strings and adds new ones related to the new Autofill addresses and payment methods settings in components/autofill_strings to share on all platforms. - Makes visual changes to the addresses and payment methods settings pages on iOS by adding a message under toggle that controls Autofill for that type. TBR=sebsg@ Bug: 873215 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8fe68a0f1776151f062006e95219a4ad41d8bb63 Reviewed-on: https://chromium-review.googlesource.com/1180556 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#585314} [modify] https://crrev.com/2e7b930c6f183906f801a0ccbd26c539a2d0cb53/components/autofill_strings.grdp [modify] https://crrev.com/2e7b930c6f183906f801a0ccbd26c539a2d0cb53/ios/chrome/browser/ui/settings/autofill_credit_card_collection_view_controller.mm [modify] https://crrev.com/2e7b930c6f183906f801a0ccbd26c539a2d0cb53/ios/chrome/browser/ui/settings/autofill_credit_card_collection_view_controller_unittest.mm [modify] https://crrev.com/2e7b930c6f183906f801a0ccbd26c539a2d0cb53/ios/chrome/browser/ui/settings/autofill_profile_collection_view_controller.mm [modify] https://crrev.com/2e7b930c6f183906f801a0ccbd26c539a2d0cb53/ios/chrome/browser/ui/settings/autofill_profile_collection_view_controller_unittest.mm [modify] https://crrev.com/2e7b930c6f183906f801a0ccbd26c539a2d0cb53/ios/chrome/browser/ui/settings/autofill_profile_settings_egtest.mm [modify] https://crrev.com/2e7b930c6f183906f801a0ccbd26c539a2d0cb53/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm [modify] https://crrev.com/2e7b930c6f183906f801a0ccbd26c539a2d0cb53/ios/chrome/browser/ui/settings/settings_egtest.mm
,
Oct 22
Strings are the same on all platforms. |
|||
►
Sign in to add a comment |
|||
Comment 1 by mahmadi@chromium.org
, Aug 10Owner: mahmadi@chromium.org
Status: Started (was: Assigned)