New issue
Advanced search Search tips

Issue 873207 link

Starred by 1 user
Status: Fixed
Owner:
yutak@chromium.org
Closed: Aug 14
Cc:
yutak@chromium.org
altimin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Logspam "Not implemented reached in virtual blink::ThreadScheduler"

Project Member Reported by w...@chromium.org, Aug 10 
Chrome Version: 69.0.3497.21
OS: ChromeOS

What steps will reproduce the problem?
(1) View the Chrome log.

What is the expected result?

No "not implemented" logging.

What happens instead?

Log is full of  "Not implemented reached in virtual blink::ThreadScheduler" messages.

Comment 1 by kojii@chromium.org, Aug 13

Components: -Blink Blink>Scheduling

Comment 2 by yutak@chromium.org, Aug 13

Owner: yutak@chromium.org
Status: Assigned (was: Untriaged)
Aha. This one, right?

[1:1:0807/105309.134898:ERROR:webthread_impl_for_utility_thread.cc(19)] Not implemented reached in virtual blink::ThreadScheduler *blink::scheduler::WebThreadImplForUtilityThread::Scheduler() const

Calling Scheduler() is legit (even if it returns nullptr), so I think this
NOTIMPLEMENTED() is bogus and should be removed.

Comment 3 by yutak@chromium.org, Aug 13

Status: Started (was: Assigned)
http://crrev.com/c/1172178
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e09e4f558cec243c4dce1e571d5095fa611d954

commit 5e09e4f558cec243c4dce1e571d5095fa611d954
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Aug 13 13:06:11 2018

Remove NOTIMPLEMENTED() in WebThreadImplForUtilityThread::Scheduler().

It's possible to reach here even if Scheduler() just returns nullptr.

Bug:  873207 
Change-Id: I6664ccaa75fbcb31e4f9e75099d85404f8db8059
Reviewed-on: https://chromium-review.googlesource.com/1172178
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582561}
[modify] https://crrev.com/5e09e4f558cec243c4dce1e571d5095fa611d954/third_party/blink/renderer/platform/scheduler/utility/webthread_impl_for_utility_thread.cc

Comment 5 by yutak@chromium.org, Aug 14

Status: Fixed (was: Started)

Comment 6 by bmil...@gmail.com, Oct 4 

[67:67:1004/163423.513246:ERROR:webthread_impl_for_utility_thread.cc(19)] Not implemented reached in virtual blink::ThreadScheduler *blink::scheduler::WebThreadImplForUtilityThread::Scheduler() const
[73:73:1004/163423.736518:ERROR:webthread_impl_for_utility_thread.cc(19)] Not implemented reached in virtual blink::ThreadScheduler *blink::scheduler::WebThreadImplForUtilityThread::Scheduler() const

still getting this on stable chromium

Comment 7 by yutak@chromium.org, Oct 5 

Will be fixed in version 70.

Comment 8 Deleted

►

Sign in to add a comment