Make sure the code doesn't crash when Flake Detection fails to create or update a bug |
|||
Issue descriptionFor example, when a bug is merged to a private bug that FindIt doesn't have access to, in this case, FindIt may fail to update that bug, it's OK for that one to fail, but it is important to make sure FindIt will continue to create or update other bugs successfully.
,
Aug 22
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/df7348e19769a8611606a074dff99fbbb865bf5b commit df7348e19769a8611606a074dff99fbbb865bf5b Author: Yuke Liao <liaoyuke@chromium.org> Date: Wed Aug 29 22:45:16 2018 [FindIt] Make Flake Detection recover from Monorail failures Flake Detection can fail while trying to create or update issues due to that it doesn't have permissions or the issue itself was deleted, and in those cases, calling Monorail APIs raises a HttpError that looks like the following: googleapiclient.errors.HttpError: <HttpError 403 when requesting https://monorail-staging.appspot.com/_ah/api/monorail/v1/projects/chromium/issues/621687?alt=json returned "User is not allowed to view this issue chromium:621687 "> This CL makes sure that Flake Detection doesn't crash when encounter such a failure, and will continue to create or update next issues. Bug: 864573 , 873190 Change-Id: Idb3533389d75966df2af2198f2aa3711cca83f84 Reviewed-on: https://chromium-review.googlesource.com/1195942 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#17298} [modify] https://crrev.com/df7348e19769a8611606a074dff99fbbb865bf5b/appengine/findit/services/flake_detection/test/flake_report_util_test.py [modify] https://crrev.com/df7348e19769a8611606a074dff99fbbb865bf5b/appengine/findit/services/flake_detection/flake_report_util.py
,
Aug 29
|
|||
►
Sign in to add a comment |
|||
Comment 1 by liaoyuke@chromium.org
, Aug 10