New issue
Advanced search Search tips

Issue 873170 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 871811
Owner: ----
Closed: Aug 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

vr: GN dependency issue: vr_base should depend on vr_build_features

Project Member Reported by marshall@chromium.org, Aug 10

Issue description

Chrome Version: 70.0.3516.0 (master #581409)
OS: Windows 10 64-bit

What steps will reproduce the problem?
(1) Build Chromium

What is the expected result?

The build should succeed.

What happens instead?

The build fails with the following error:

[15724/33687] CXX obj/chrome/browser/vr/vr_base/assets_loader.obj
FAILED: obj/chrome/browser/vr/vr_base/assets_loader.obj 
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes  -imsvcc:\\win10sdk\Include\10.0.17134.0\um -imsvcc:\\win10sdk\Include\10.0.17134.0\ucrt -imsvcc:\\win10sdk\Include\10.0.17134.0\shared -imsvcc:\\win10sdk\Include\10.0.17134.0\winrt -imsvcc:\\VC\Tools\MSVC\14.14.26428\include -imsvcc:\\VC\Tools\MSVC\14.14.26428\atlmfc\include -DVR_IMPLEMENTATION -DVR_BASE_IMPLEMENTATION -DVR_UI_IMPLEMENTATION -DV8_DEPRECATION_WARNINGS -DDCHECK_ALWAYS_ON=1 -DUSE_AURA=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED "-DCR_CLANG_REVISION=\"338452-1\"" -D_HAS_NODISCARD -D_HAS_EXCEPTIONS=0 -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=1 -DWIN32 -D_SECURE_ATL -D_USING_V110_SDK71_ -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=0x0A000002 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DWEBP_EXTERN=extern -DUSE_EGL -DANGLE_ENABLE_RELEASE_ASSERTS -DTOOLKIT_VIEWS=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1 "-DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\"" -DGR_GL_FUNCTION_TYPE=__stdcall -DLEVELDB_PLATFORM_CHROMIUM=1 -DDeleteFile=DeleteFileW -DOS_WIN -I../.. -Igen -I../../third_party/libyuv/include -I../../third_party/libwebp/src -I../../third_party/wtl/include -I../../third_party/khronos -I../../gpu -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/libwebm/source -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/skia/modules/skottie/include -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../third_party/boringssl/src/include /utf-8 /X -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -fcomplete-member-pointers /Gy /FS /bigobj /d2FastFail /Zc:sizedDealloc- -fmsc-version=1911 -m64 /Brepro /W4 -Wimplicit-fallthrough -Wthread-safety /WX /wd4091 /wd4127 /wd4251 /wd4275 /wd4312 /wd4324 /wd4351 /wd4355 /wd4503 /wd4589 /wd4611 /wd4100 /wd4121 /wd4244 /wd4505 /wd4510 /wd4512 /wd4610 /wd4838 /wd4995 /wd4996 /wd4456 /wd4457 /wd4458 /wd4459 /wd4200 /wd4201 /wd4204 /wd4221 /wd4245 /wd4267 /wd4305 /wd4389 /wd4702 /wd4701 /wd4703 /wd4661 /wd4706 /wd4715 /wd4702 -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-user-defined-warnings -Wno-unused-lambda-capture -Wno-null-pointer-arithmetic -Wno-enum-compare-switch -Wno-ignored-pragma-optimize /O1 /Ob2 /Oy- /Zc:inline /Gw /Oi /Z7 -fno-standalone-debug /MT -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-inconsistent-missing-override /wd4267 /TP /wd4577 /GR- /c ../../chrome/browser/vr/assets_loader.cc /Foobj/chrome/browser/vr/vr_base/assets_loader.obj /Fd"obj/chrome/browser/vr/vr_base_cc.pdb"
../../chrome/browser/vr/assets_loader.cc(16,10):  fatal error: 'chrome/browser/vr/vr_features.h' file not found
#include "chrome/browser/vr/vr_features.h"
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Please use labels and text to provide additional information.

This was likely broken by https://crrev.com/4dafc60789. The problem is that assets_loader.cc (in the vr_base target) includes vr_features.h (generated by the vr_build_features target) without the vr_base target depending on the vr_build_features target.
 
I don't have a Windows PC right now to repro this issue. Does it build if you add the vr_build_features as a dependency of vr_base?
@comment#1: Yes, it fixes the build error for me.
If you upload this change, I'm happy to approve it :)
No problem. I'll do it next week :)
Mergedinto: 871811
Status: Duplicate (was: Untriaged)
Looks like this was fixed a few days ago in https://chromium.googlesource.com/chromium/src/+/cda89e62f9e9678eb50c877f7a833b3e5dd946ef

Sign in to add a comment