New issue
Advanced search Search tips

Issue 873158 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

CVC placeholder should be translated to an abbreviation

Project Member Reported by ftirelo@chromium.org, Aug 10

Issue description

Chrome Version: M69+ for sure, but the issue has been there for a while
OS: all

What steps will reproduce the problem?
(1) Set the browser language to French.
(2) Make sure Autofill is enabled for the profile and there is at least one Google Pay card associated to the profile.
(3) Navigate to https://dump-truck.appspot.com/usecase-address_and_cc_on_same_page/address_and_cc.html
(4) Click on the "Name on card" field and select the credit card suggestion corresponding to the Google Pay card.

A prompt to enter the CVC should appear.

What is the expected result?

The CVC field's placeholder should be "CVC".

What happens instead?

The CVC field's placeholder is "Crypto..."

More context: Most likely, we are sharing the French translations with other properties that don't have the same space restraints.
 
Reuploading the image with a highlight on the issue.
CVC Prompt - French.PNG
14.5 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4474a47ab71cc6533f12941dcae230d528660ced

commit 4474a47ab71cc6533f12941dcae230d528660ced
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Fri Aug 10 17:28:24 2018

[Card unmask dialog] Prefer to translate CVC to an abbreviated form

The current CVC placeholder string is translated to the full form in
some languages and doesn't look well on the card unmask dialog (for
example, it looks like "Crypto..." in French). This adds a restraint
to the number of characters it should be translated to and add a
"meaning" tag to ensure the translation is not shared with other
properties.

Bug:  873158 

Change-Id: I1ffd5154ef94705efe86dae842fbf913b09b6a36
Reviewed-on: https://chromium-review.googlesource.com/1170586
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582227}
[modify] https://crrev.com/4474a47ab71cc6533f12941dcae230d528660ced/components/autofill_strings.grdp

This can also be addressed on the L10n side by updating their glossaries. I submitted an update request: https://gloc-qm.appspot.com/glossary-terms/cvc-8fa7f73a/
Cc: susan.boorgula@chromium.org
Labels: Needs-Feedback
Tested this issue on Windows 10 and Mac OS 10.13.3 on the build without fix 70.0.3503.0 and build with Fix 70.0.3521.0 and unable to reproduce the issue by following the below steps.

1. Launched Chrome and added a credit card in Payment methods and the Autofill forms is enabled.
2. Set the browser language to French and relaunched Chrome.
3. Navigated to https://dump-truck.appspot.com/usecase-address_and_cc_on_same_page/address_and_cc.html and on clicked on "Name on card" field and selected the credit card suggestion, the values are auto filled.
4. Cannot observe any prompt to enter the CVC.
Attached is the screen cast for reference.

ftirelo@ Request you to check and confirm if anything is missed from our end in verifying the issue?

Thanks.
873158-M70.mp4
1.7 MB View Download
susan.boorgula@: Thanks for the test.

I think the card is saved locally. The CVC prompt is only shown when the card comes from Google Pay and is not saved locally, so please make sure that:
 - you are logged in;
 - option "Payment methods and addresses using Google Pay" in chrome://settings/syncSetup is enabled;
 - you have a credit card in Google Pay (you can add one to https://pay.google.com/payments/home, or I can provide access to a test account for that - access must be granted to your @google.com);
 - the card is not saved locally (if you see text "copied to chrome" beside the credit card data in chrome://settings/payments, please select "clear copy" on the menu beside the expiration data).

Please let me know if you need more details.
Labels: TE-NeedsTriageFromHYD
ftirelo@ Thanks for the update.

Adding 'TE-NeedsTriageFromHYD' label as this issue needs Corp account to verify the issue as per comment #5.
Routing to Inhouse team to check and help in verifying the fix on the latest M-70 build.

Thanks..
Cc: kkaluri@chromium.org
Labels: TE-Verified-M70 TE-Verified-70.0.3522.0
Verified this issue on Mac 10.13.6 with chrome #70.0.3522.0 and observed the fix is working as expected. Hence adding TE verified labels.

Attaching the screenshot for reference.
873158.png
165 KB View Download
Labels: -TE-Verified-M70 -TE-Verified-70.0.3522.0
The reason why this is working is because the new string has not been translated, so we are getting the English string, which happens to be "CVC". I will leave this bug open and ping it again for testing once the translation becomes available.
Translations have been propagated and this is fixed.

kkaluri@: can you please verify this again?
Status: Fixed (was: Assigned)

Sign in to add a comment