Accessory impression logged only once |
|||
Issue descriptionChrome Version: 69 OS: Android What steps will reproduce the problem? (e.g. on imdb.com) (1) Tap a name field (2) Tap a password field (with automatic generation) What is the expected result? (Verify on chrome://histogram) Logs two impressions of the keyboard accessory bar. Logs one impression of the keyboard accessory generation action. What happens instead? One impression of the bar is logged and none of the generation action. Why? Most likely because metrics are recorded when the accessory shows up but the refocus doesn't change the shown state - it's permanently visible. What is the impact? Overstated CTR for password generation in 69. What is still correct? Total number of clicks. Impressions of the bar itself.
,
Aug 10
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57bd38debf29ce28834de580209e4e20d09c65da commit 57bd38debf29ce28834de580209e4e20d09c65da Author: Friedrich Horschig <fhorschig@chromium.org> Date: Tue Aug 14 10:07:32 2018 [Android] Record keyboard accessory bar metrics up to once Before this CL, the accessory bar wouldn't add impressions to delayed appearing actions. This CL ensures this is done once (per new set of actions) while keeping the constraint that every bar impression happens exactly once. Bug: 873143 Change-Id: I4de6c8f8e95321176d9bca19459d6e9d2cdae746 Reviewed-on: https://chromium-review.googlesource.com/1171227 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#582881} [modify] https://crrev.com/57bd38debf29ce28834de580209e4e20d09c65da/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java [modify] https://crrev.com/57bd38debf29ce28834de580209e4e20d09c65da/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetCoordinator.java [modify] https://crrev.com/57bd38debf29ce28834de580209e4e20d09c65da/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java [modify] https://crrev.com/57bd38debf29ce28834de580209e4e20d09c65da/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMetricsRecorder.java [modify] https://crrev.com/57bd38debf29ce28834de580209e4e20d09c65da/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryControllerTest.java
,
Aug 14
|
|||
►
Sign in to add a comment |
|||
Comment 1 by fhorschig@chromium.org
, Aug 10