New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 873143 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 853794



Sign in to add a comment

Accessory impression logged only once

Project Member Reported by fhorschig@chromium.org, Aug 10

Issue description

Chrome Version: 69
OS: Android

What steps will reproduce the problem? (e.g. on imdb.com)
(1) Tap a name field
(2) Tap a password field (with automatic generation)

What is the expected result? (Verify on chrome://histogram)
Logs two impressions of the keyboard accessory bar.
Logs one impression of the keyboard accessory generation action.

What happens instead?
One impression of the bar is logged and none of the generation action.

Why?
Most likely because metrics are recorded when the accessory shows up but the refocus doesn't change the shown state - it's permanently visible.

What is the impact?
Overstated CTR for password generation in 69.

What is still correct?
Total number of clicks.
Impressions of the bar itself.
 
Description: Show this description
Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57bd38debf29ce28834de580209e4e20d09c65da

commit 57bd38debf29ce28834de580209e4e20d09c65da
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Tue Aug 14 10:07:32 2018

[Android] Record keyboard accessory bar metrics up to once

Before this CL, the accessory bar wouldn't add impressions to delayed
appearing actions. This CL ensures this is done once (per new set of
actions) while keeping the constraint that every bar impression happens
exactly once.

Bug:  873143 
Change-Id: I4de6c8f8e95321176d9bca19459d6e9d2cdae746
Reviewed-on: https://chromium-review.googlesource.com/1171227
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582881}
[modify] https://crrev.com/57bd38debf29ce28834de580209e4e20d09c65da/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java
[modify] https://crrev.com/57bd38debf29ce28834de580209e4e20d09c65da/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetCoordinator.java
[modify] https://crrev.com/57bd38debf29ce28834de580209e4e20d09c65da/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java
[modify] https://crrev.com/57bd38debf29ce28834de580209e4e20d09c65da/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMetricsRecorder.java
[modify] https://crrev.com/57bd38debf29ce28834de580209e4e20d09c65da/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryControllerTest.java

Status: Fixed (was: Started)

Sign in to add a comment