New issue
Advanced search Search tips

Issue 873128 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Aug 13
Cc:
jlebel@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

ConsentBump isn't displayed as modal

Project Member Reported by gambard@chromium.org, Aug 10 
With ForcedConsentBump flag.
iPhone + landscape/iPad only

What steps will reproduce the problem?
(1) Relaunch the app

What is the expected result?
The ConsentBump shouldn't be fullscreen.

What happens instead?
It is.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77121bde31ed24298991cf267bc38a8dca03b256

commit 77121bde31ed24298991cf267bc38a8dca03b256
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Aug 13 08:35:21 2018

[iOS] Use UIModalPresentationPageSheet for ConsentBump

The ConsentBump should be displayed modally on iPhone+ landscape and
iPad.

Bug:  873128 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I96482c930ef1b6b94509e8aafd7b1691b76b2e28
Reviewed-on: https://chromium-review.googlesource.com/1170823
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582529}
[modify] https://crrev.com/77121bde31ed24298991cf267bc38a8dca03b256/ios/chrome/browser/ui/browser_view_controller.mm

Comment 2 by gambard@chromium.org, Aug 13

Status: Fixed (was: Assigned)
►

Sign in to add a comment