memory.desktop/Trivial* pages failing flakily on win-10-perf |
|||
Issue descriptionWe have desymbolized stack: (Build https://ci.chromium.org/buildbot/chromium.perf/win-10-perf/124) https://chrome-isolated.appspot.com/browse?namespace=default-gzip&digest=5d551e2c2df2ff3e61eab751bd20f5e10bdb019e&as=memory.desktop%5Cbenchmark_log.txt (Build https://ci.chromium.org/buildbot/chromium.perf/win-10-perf/123) https://chrome-isolated.appspot.com/browse?namespace=default-gzip&digest=5c987412118505e2a35465731023f9cf2c8cf986&as=memory.desktop%5Cbenchmark_log.txt Assign to Erik, benchmark owner
,
Aug 10
Okay, there are a bunch of problems here: catapult: 1) We're trying to make the browser 6 times. [even though retry = 3]. The first 5 crash, but we don't have symbolized crash dumps. The last one suffers a timeout, which triggers a CHECK(false), which is symbolized. https://chrome-isolated.appspot.com/browse?namespace=default-gzip&digest=5d551e2c2df2ff3e61eab751bd20f5e10bdb019e&as=memory.desktop%5Cbenchmark_log.txt Search for "Browser creation failed". 2) We're missing the browser logs. See https://www.chromium.org/for-testers/enable-logging for more details on how to get the logs. chrome: 3) SystemInfoHandlerGpuObserver has a 5s timeout for GPU process startup/information gathering. This is too short. EVen successful callbacks are taking ~3s. example: """ (INFO) 2018-08-09 21:07:10,072 browser._LogBrowserInfo:100 Browser started (pid=1120). (INFO) 2018-08-09 21:07:10,072 browser._LogBrowserInfo:103 OS: win win10 (INFO) 2018-08-09 21:07:10,072 browser._LogBrowserInfo:106 Detailed OS version: 10.0.16299 (INFO) 2018-08-09 21:07:13,713 browser._LogBrowserInfo:112 Browser command line: [emitted for brevity] (INFO) 2018-08-09 21:07:13,713 browser._LogBrowserInfo:115 GPU device 0: VENDOR = 0x8086 (Google Inc.), DEVICE = 0x5912 (ANGLE (Intel(R) HD Graphics 630 Direct3D11 vs_5_0 ps_5_0)) (INFO) 2018-08-09 21:07:13,713 browser._LogBrowserInfo:117 GPU Attributes: ... """ Notice the 3s delay before browser._LogBrowserInfo is able to log GPU info. This is because "system_info = self.GetSystemInfo()" takes 3s to run.
,
Aug 10
timeout increase CL here: https://chromium-review.googlesource.com/c/chromium/src/+/1170584
,
Aug 10
,
Aug 10
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c9cf51bc70b424ce8d9849d24c115a7f6930772 commit 1c9cf51bc70b424ce8d9849d24c115a7f6930772 Author: Erik Chen <erikchen@chromium.org> Date: Fri Aug 10 22:55:52 2018 Increase DevTools SystemInfoGPU timeout for Windows. Before this CL, DevTools would crash the browser if it did not get a response in 5 seconds. This timeout is too low for Windows. On Catapult perf tests on Windows, it takes ~3 seconds for the GPU process to respond on average, and sometimes it takes more than 5 seconds. Bug: 873112 Change-Id: I67ee82a1a75df0ba9e1b483a58c66c56a8bf2213 Reviewed-on: https://chromium-review.googlesource.com/1170584 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582375} [modify] https://crrev.com/1c9cf51bc70b424ce8d9849d24c115a7f6930772/content/browser/devtools/protocol/system_info_handler.cc
,
Aug 14
Is htis still a problem? Closing for now -- reopen if issue recurs.
,
Aug 14
Great work! memory.desktop has been super stable since then: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=performance_test_suite&sortColumn=test&sortOrder=forward&builder=chromium.perf%3Awin-10-perf |
|||
►
Sign in to add a comment |
|||
Comment 1 by erikc...@chromium.org
, Aug 10