New issue
Advanced search Search tips

Issue 873110 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: ----



Sign in to add a comment

interactive_ui_tests (CrSettingsSyncPageTest.All) failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Aug 10

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of vitaliii@google.com

interactive_ui_tests failing on multiple builders

Builders failed on: 
- Win7 Tests (dbg)(1): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29


 
 Issue 873108  has been merged into this issue.
 Issue 873109  has been merged into this issue.
Owner: droger@chromium.org
Status: Assigned (was: Available)
I will revert the CL.
The reland CL is https://chromium-review.googlesource.com/c/chromium/src/+/1170202 (that's the one I will be reverting).
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2f75f326f9fb7b36d8829440104d599474f3bda

commit f2f75f326f9fb7b36d8829440104d599474f3bda
Author: vitaliii <vitaliii@chromium.org>
Date: Fri Aug 10 11:35:04 2018

Revert "Reland "[Settings] UserEvents depends on history and passphrase""

This reverts commit 68947d7403d7c7bc19572b19ae3b14a13ec37aa8.

Reason for revert: this may break interactive_ui_tests (CrSettingsSyncPageTest.All) on multiple builders.

Original change's description:
> Reland "[Settings] UserEvents depends on history and passphrase"
> 
> This is a reland of 13143b64ae10001dd25dcb8b2d8e707b9e439382
> 
> Original change's description:
> > [Settings] UserEvents depends on history and passphrase
> >
> > The user events UI toggle should be grayed out and turned off
> > when there is a passphrase or when history sync is disabled.
> > Note that this is purely a UI change: the internal sync datatype
> > is not really turned off in that case, and we assume that the Sync
> > engines will correctly stop syncing user events in these cases,
> > even if the preference is still ON.
> >
> > Bug: 865522, 865537
> > Change-Id: I04844e2ab9c631300e88f02bbedd712f7618bc32
> > Reviewed-on: https://chromium-review.googlesource.com/1160658
> > Reviewed-by: Scott Chen <scottchen@chromium.org>
> 
> TBR=droger
> 
> Bug: 865522, 865537
> Change-Id: Ifae79eaf00a42c3b536bc54fa5d23cbcbcabd18a
> Reviewed-on: https://chromium-review.googlesource.com/1170202
> Commit-Queue: David Roger <droger@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582078}

TBR=droger@chromium.org,scottchen@chromium.org

Change-Id: I2187610fb6ebbeaefff001b858b3585b786ed181
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 865522, 865537, 873110
Reviewed-on: https://chromium-review.googlesource.com/1170782
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582118}
[modify] https://crrev.com/f2f75f326f9fb7b36d8829440104d599474f3bda/chrome/browser/resources/settings/people_page/sync_browser_proxy.js
[modify] https://crrev.com/f2f75f326f9fb7b36d8829440104d599474f3bda/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/f2f75f326f9fb7b36d8829440104d599474f3bda/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/f2f75f326f9fb7b36d8829440104d599474f3bda/chrome/test/data/webui/settings/people_page_sync_page_test.js

Labels: -Sheriff-Chromium
Please have a look, thank you!
This test also fails in network_service_interactive_ui_tests on some platforms.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec52747a5abc25a862843edca761104b3c319764

commit ec52747a5abc25a862843edca761104b3c319764
Author: Gabriel Charette <gab@chromium.org>
Date: Mon Jan 14 16:16:49 2019

[ui_controls] Unflake Send*NotifyWhenDone() on Windows

ui_controls::Send*NotifyWhenDone() can be flaky when invoked after
ui_controls::Send*() as the former can decide to notify based on
observing a yet-to-be-processed event from the latter (or even a
yet-to-be-processed event emitted by unrelated code) and thus notify too
early, resuming and testing conditions that have yet to be met.

Solution: defer the notification if the system queue has pending events
of the same type awaiting dispatch.

Note: mouse move can be repeated indefinitely during a drag, as such we
consider a mouse move complete when it hits the target regardless of
remaining mouse move messages in the queue.

@ BUG OWNERS : This might unflake many currently disabled tests. I've
CC'ed interactive_ui_tests + Windows bugs, please try to re-enable your
test after this CL if you think it might be related.

Bug:  892228 , 640996, 897801,893078,876224,875443,873110,852786,850343,848049,846695,840369,798492,756338,751031,665296,651906,499858,468660,419468,238347,131612,106489,97777,92467
Change-Id: I548856a3948ff71a145435799b4ba3e689561f14
Reviewed-on: https://chromium-review.googlesource.com/c/1392178
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622470}
[modify] https://crrev.com/ec52747a5abc25a862843edca761104b3c319764/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc
[modify] https://crrev.com/ec52747a5abc25a862843edca761104b3c319764/ui/base/test/ui_controls_internal_win.cc

Sign in to add a comment