New issue
Advanced search Search tips

Issue 873103 link

Starred by 1 user
Status: Fixed
Owner:
dvadym@chromium.org
Closed: Aug 29
Cc:
vasi...@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Redundant dependency on password_controller.js

Project Member Reported by scottwu@chromium.org, Aug 10 
Looks like target "injected_js" in ios/chrome/browser/passwords/BUILD.gn is not being used.
Currently password_controller.js should be injected by chrome_bundle_main_frame in //ios/chrome/browser/web/BUILD.gn, so the dependency here should be redundant.

Comment 1 by stkhapugin@chromium.org, Aug 10

Cc: vabr@chromium.org vasi...@chromium.org
Components: UI>Browser>Passwords
Owner: dvadym@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by vabr@chromium.org, Aug 28 

It seems like the situation changed a lot recently, due to moving stuff in the component (because of web view, issue 865114, done by the reporter).

For production code, I now see password_controller.js mentioned directly in these BUILD.gn files:
  ios/chrome/browser/web/BUILD.gn
  ios/web_view/BUILD.gn

Is this now OK, or needs some more thought?

Comment 3 by scottwu@chromium.org, Aug 29

Status: Fixed (was: Assigned)
Yes it is fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1168959
We can close this bug now.

Comment 4 by vabr@chromium.org, Nov 29

Cc: -vabr@chromium.org
►

Sign in to add a comment