New issue
Advanced search Search tips

Issue 873100 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

AEC3: The ability to adjust the AEC3 performance is limited by the filter lengths

Project Member Reported by peah@chromium.org, Aug 10

Issue description

There is a restriction in the AEC3 code that the shadow and main filters must have the same lengths. In some cases, it may be beneficial for these to have different lengths as the requirements of adaptation speed is typically different for the two filters. Therefore, it would be desired for the AEC3 code to support  different filter lengths for the main and shadow filters.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/ee8ad5ff8a20fed347f7fd134920bd2e675f32f4

commit ee8ad5ff8a20fed347f7fd134920bd2e675f32f4
Author: Per Åhgren <peah@webrtc.org>
Date: Fri Aug 10 19:59:50 2018

AEC3: Allow the main and shadow filters to have different lengths

This CL changes the AEC3 code to allow the main and shadow filters
to have different lengths.

Bug:  webrtc:9614 , chromium:873100 
Change-Id: I3ec2861d496986610d5a73db5771bbe9b8bf7dcd
Reviewed-on: https://webrtc-review.googlesource.com/93465
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24265}
[modify] https://crrev.com/ee8ad5ff8a20fed347f7fd134920bd2e675f32f4/modules/audio_processing/aec3/render_buffer.cc
[modify] https://crrev.com/ee8ad5ff8a20fed347f7fd134920bd2e675f32f4/modules/audio_processing/aec3/render_buffer.h
[modify] https://crrev.com/ee8ad5ff8a20fed347f7fd134920bd2e675f32f4/modules/audio_processing/aec3/subtractor.cc
[modify] https://crrev.com/ee8ad5ff8a20fed347f7fd134920bd2e675f32f4/modules/audio_processing/aec3/subtractor_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/302120835fb01b19784190f7cb2ff2e9eb981fba

commit 302120835fb01b19784190f7cb2ff2e9eb981fba
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Aug 11 07:30:37 2018

Roll src/third_party/webrtc f5f537337258..f820a5ea1c5c (3 commits)

https://webrtc.googlesource.com/src.git/+log/f5f537337258..f820a5ea1c5c


git log f5f537337258..f820a5ea1c5c --date=short --no-merges --format='%ad %ae %s'
2018-08-10 steveanton@webrtc.org Fix use after move in SafeSetError
2018-08-10 peah@webrtc.org AEC3: Allow the main and shadow filters to have different lengths
2018-08-10 peah@webrtc.org AEC3: Further utilize the shadow filter to boost adaptation


Created with:
  gclient setdep -r src/third_party/webrtc@f820a5ea1c5c

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG= chromium:873100 , chromium:873074 
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I17c5ef48542d75bd785d1bdf3ac026a23ed46229
Reviewed-on: https://chromium-review.googlesource.com/1171447
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582436}
[modify] https://crrev.com/302120835fb01b19784190f7cb2ff2e9eb981fba/DEPS

Labels: M-70
Status: Fixed (was: Started)

Sign in to add a comment