New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 873098 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 7
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

Set up dynamicmodule repository

Project Member Reported by amalova@chromium.org, Aug 10

Issue description

Set up dynamicmodule repository


 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eca6385200209b9756f3e011b0f1c089c194209

commit 1eca6385200209b9756f3e011b0f1c089c194209
Author: Anna Malova <amalova@chromium.org>
Date: Fri Aug 10 17:26:47 2018

Add dynamicmodule in Chromium repository DEPS

Bug:  873098 
Change-Id: Ifafc4edec8ddae8da621908f69fdf3a39e9e8f8a
Reviewed-on: https://chromium-review.googlesource.com/1170698
Commit-Queue: Anna Malova <amalova@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582225}
[modify] https://crrev.com/1eca6385200209b9756f3e011b0f1c089c194209/DEPS
[modify] https://crrev.com/1eca6385200209b9756f3e011b0f1c089c194209/third_party/.gitignore

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/330612ff44a3beadd809c9ae91f240b696f1bcdc

commit 330612ff44a3beadd809c9ae91f240b696f1bcdc
Author: Anna Malova <amalova@chromium.org>
Date: Fri Sep 07 14:08:55 2018

Migrate dynamic module interface to DEPS.

Remove the dynamic module interface defined in the Chromium repository in favor of the copy pulled in via DEPS and updates the build files correspondingly.

Bug:  873098 
Change-Id: Ic8b38906eceb7f9bf46ed9c95e5d7e3dd82b8e5e
Reviewed-on: https://chromium-review.googlesource.com/1172427
Commit-Queue: Anna Malova <amalova@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589509}
[modify] https://crrev.com/330612ff44a3beadd809c9ae91f240b696f1bcdc/DEPS
[modify] https://crrev.com/330612ff44a3beadd809c9ae91f240b696f1bcdc/chrome/android/BUILD.gn
[delete] https://crrev.com/96dede7dbfec5ccdccd1efd5c5342b19cd632556/chrome/android/java/src/org/chromium/chrome/browser/customtabs/dynamicmodule/IActivityDelegate.aidl
[delete] https://crrev.com/96dede7dbfec5ccdccd1efd5c5342b19cd632556/chrome/android/java/src/org/chromium/chrome/browser/customtabs/dynamicmodule/IActivityHost.aidl
[delete] https://crrev.com/96dede7dbfec5ccdccd1efd5c5342b19cd632556/chrome/android/java/src/org/chromium/chrome/browser/customtabs/dynamicmodule/IModuleEntryPoint.aidl
[delete] https://crrev.com/96dede7dbfec5ccdccd1efd5c5342b19cd632556/chrome/android/java/src/org/chromium/chrome/browser/customtabs/dynamicmodule/IModuleHost.aidl
[delete] https://crrev.com/96dede7dbfec5ccdccd1efd5c5342b19cd632556/chrome/android/java/src/org/chromium/chrome/browser/customtabs/dynamicmodule/IObjectWrapper.aidl
[modify] https://crrev.com/330612ff44a3beadd809c9ae91f240b696f1bcdc/third_party/.gitignore
[add] https://crrev.com/330612ff44a3beadd809c9ae91f240b696f1bcdc/third_party/cct_dynamic_module/BUILD.gn
[add] https://crrev.com/330612ff44a3beadd809c9ae91f240b696f1bcdc/third_party/cct_dynamic_module/OWNERS
[add] https://crrev.com/330612ff44a3beadd809c9ae91f240b696f1bcdc/third_party/cct_dynamic_module/README.chromium
[add] https://crrev.com/330612ff44a3beadd809c9ae91f240b696f1bcdc/third_party/cct_dynamic_module/common.aidl

Status: Fixed (was: Started)

Sign in to add a comment