AEC3: Transparency loss when the main filter is inaccurate |
||||||
Issue descriptionDuring investigations it has been shown that the AEC3 loses parts of the nearend speech when the main filter is inaccurate or cannot be trusted. This sometimes has a really strong impact on the call quality, in particular during the initial parts of the call.
,
Aug 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/302120835fb01b19784190f7cb2ff2e9eb981fba commit 302120835fb01b19784190f7cb2ff2e9eb981fba Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat Aug 11 07:30:37 2018 Roll src/third_party/webrtc f5f537337258..f820a5ea1c5c (3 commits) https://webrtc.googlesource.com/src.git/+log/f5f537337258..f820a5ea1c5c git log f5f537337258..f820a5ea1c5c --date=short --no-merges --format='%ad %ae %s' 2018-08-10 steveanton@webrtc.org Fix use after move in SafeSetError 2018-08-10 peah@webrtc.org AEC3: Allow the main and shadow filters to have different lengths 2018-08-10 peah@webrtc.org AEC3: Further utilize the shadow filter to boost adaptation Created with: gclient setdep -r src/third_party/webrtc@f820a5ea1c5c The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= chromium:873100 , chromium:873074 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I17c5ef48542d75bd785d1bdf3ac026a23ed46229 Reviewed-on: https://chromium-review.googlesource.com/1171447 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582436} [modify] https://crrev.com/302120835fb01b19784190f7cb2ff2e9eb981fba/DEPS
,
Aug 12
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/f4cf64ec066953d7b175b124a7617557d0c7f27c commit f4cf64ec066953d7b175b124a7617557d0c7f27c Author: Per Åhgren <peah@webrtc.org> Date: Sun Aug 12 20:40:04 2018 AEC3: Enforcing nonlinear mode when transparent mode is active This CL ensures that the linear echo prediction mode is not used when the transparent mode is active. TBR: saza@webrtc.org,gustaf@webrtc.org Bug: webrtc:9612 , chromium:873074 Change-Id: I25cda5226251df769b6524594ea8a2b78532aaec Reviewed-on: https://webrtc-review.googlesource.com/93740 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24268} [modify] https://crrev.com/f4cf64ec066953d7b175b124a7617557d0c7f27c/modules/audio_processing/aec3/aec_state.cc [modify] https://crrev.com/f4cf64ec066953d7b175b124a7617557d0c7f27c/modules/audio_processing/aec3/aec_state.h
,
Aug 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28674e1331623f484d7b71614c2d816688e40d0a commit 28674e1331623f484d7b71614c2d816688e40d0a Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sun Aug 12 22:58:38 2018 Roll src/third_party/webrtc 656d609a952a..f4cf64ec0669 (1 commits) https://webrtc.googlesource.com/src.git/+log/656d609a952a..f4cf64ec0669 git log 656d609a952a..f4cf64ec0669 --date=short --no-merges --format='%ad %ae %s' 2018-08-12 peah@webrtc.org AEC3: Enforcing nonlinear mode when transparent mode is active Created with: gclient setdep -r src/third_party/webrtc@f4cf64ec0669 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= chromium:873074 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib0004e39737a41814ac3b77b6143c6f9621c8f93 Reviewed-on: https://chromium-review.googlesource.com/1172103 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582480} [modify] https://crrev.com/28674e1331623f484d7b71614c2d816688e40d0a/DEPS
,
Aug 13
We would like to merge this issue into M69. It further addresses an important issue in the echo canceller that was emphasized with some of the changes done for M69. The code has been tested in Chrome Canary and has been found to work well. The merge is considered to be very safe, as the feature is only active beneath an experiment flag, and also has a specific kill-switch. The CLs that would be part of the merge are -https://webrtc-review.googlesource.com/c/src/+/93461 -https://webrtc-review.googlesource.com/c/src/+/93740
,
Aug 13
This bug requires manual review: Less than 18 days to go before AppStore submit on M69 Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 13
,
Aug 13
Approving merge to M69 branch 3497 based on comment #5. Please merge ASAP. Thank you.
,
Aug 14
The two mentioned CLs have now been merged to M69. Thanks. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Aug 10