New issue
Advanced search Search tips

Issue 873073 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 14
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

perfetto_content_browsertests failing flakily on chromium.linux/Cast Linux

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Aug 10

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of vitaliii@google.com

perfetto_content_browsertests failing flakily on chromium.linux/Cast Linux

Builders failed on: 
- Cast Linux: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux


 
Out of last 50 builds, 6 were red due to perfetto_content_browsertests failing.

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/57118
TracingControllerTest.EnableAndStopTracingWithEmptyFile

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/57125
TracingControllerTest.DoubleStopTracing

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/57139
TracingControllerTest.DoubleStopTracing

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/57156
TracingControllerTest.DoubleStopTracing

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/57165
TracingControllerTest.EnableAndStopTracingWithEmptyFile

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/57166
TracingControllerTest.DoubleStopTracing

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/57156
TracingControllerTest.DoubleStopTracing
Log from https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/57166 for TracingControllerTest.DoubleStopTracing

[ RUN      ] TracingControllerTest.DoubleStopTracing
DevTools listening on ws://127.0.0.1:43105/devtools/browser/80fffb5a-c9bb-45ab-ac86-3f15b4eab14b
tracing_service_impl.cc: Consumer called DisableTracing() but tracing was not active
tracing_service_impl.cc: Enabled tracing, #sources:2, duration:0 ms, #buffers:1, total buffer size:409600 KB, total sessions:1
[10800:10800:0810/001626.252670:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1
[10800:10800:0810/001626.252774:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x000003525bac base::debug::StackTrace::StackTrace()
#1 0x00000328d895 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7fc618da5cb0 <unknown>
#3 0x7fc618e6d6d3 epoll_wait
#4 0x000003540d6d epoll_dispatch
#5 0x00000353e7ec event_base_loop
#6 0x000003536141 base::MessagePumpLibevent::Run()
#7 0x0000034cca05 base::RunLoop::Run()
#8 0x000001906bc5 content::TracingControllerTest_DoubleStopTracing_Test::RunTestOnMainThread()
#9 0x00000328cd18 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#10 0x000003311758 content::ShellBrowserMainParts::PreMainMessageLoopRun()
#11 0x000002422851 content::BrowserMainLoop::PreMainMessageLoopRun()
#12 0x000002786f07 content::StartupTaskRunner::RunAllTasksNow()
#13 0x0000024212ed content::BrowserMainLoop::CreateStartupTasks()
#14 0x000002424dc3 content::BrowserMainRunnerImpl::Initialize()
#15 0x0000033110a9 ShellBrowserMain()
#16 0x0000032d5d8f content::ShellMainDelegate::RunProcess()
#17 0x0000023588fb content::ContentMainRunnerImpl::Run()
#18 0x0000047a02fb service_manager::Main()
#19 0x0000023572b1 content::ContentMain()
#20 0x00000328c90c content::BrowserTestBase::SetUp()
#21 0x00000328282f content::ContentBrowserTest::SetUp()
#22 0x00000217906d testing::Test::Run()
#23 0x000002179cd0 testing::TestInfo::Run()
#24 0x00000217a1e7 testing::TestCase::Run()
#25 0x000002185ae7 testing::internal::UnitTestImpl::RunAllTests()
#26 0x00000218565d testing::UnitTest::Run()
#27 0x0000032bb0e1 base::TestSuite::Run()
#28 0x000003286377 content::ContentTestLauncherDelegate::RunTestSuite()
#29 0x0000032a5874 content::LaunchTests()
#30 0x000003286330 main
#31 0x7fc618d90f45 __libc_start_main
#32 0x00000137802a _start
Log from https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/57165 for
TracingControllerTest.EnableAndStopTracingWithEmptyFile:

[ RUN      ] TracingControllerTest.EnableAndStopTracingWithEmptyFile
DevTools listening on ws://127.0.0.1:33402/devtools/browser/b6d1d110-cce2-4c6f-abdb-dbfcb18929c0
tracing_service_impl.cc: Consumer called DisableTracing() but tracing was not active
tracing_service_impl.cc: Enabled tracing, #sources:2, duration:0 ms, #buffers:1, total buffer size:409600 KB, total sessions:1
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x000003525bac base::debug::StackTrace::StackTrace()
#1 0x00000328d895 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f7de9a65cb0 <unknown>
#3 0x7f7de9b2d6d3 epoll_wait
#4 0x000003540d6d epoll_dispatch
#5 0x00000353e7ec event_base_loop
#6 0x000003536141 base::MessagePumpLibevent::Run()
#7 0x0000034cca05 base::RunLoop::Run()
#8 0x000001906655 content::TracingControllerTest_EnableAndStopTracingWithEmptyFile_Test::RunTestOnMainThread()
#9 0x00000328cd18 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#10 0x000003311758 content::ShellBrowserMainParts::PreMainMessageLoopRun()
#11 0x000002422851 content::BrowserMainLoop::PreMainMessageLoopRun()
#12 0x000002786f07 content::StartupTaskRunner::RunAllTasksNow()
#13 0x0000024212ed content::BrowserMainLoop::CreateStartupTasks()
#14 0x000002424dc3 content::BrowserMainRunnerImpl::Initialize()
#15 0x0000033110a9 ShellBrowserMain()
#16 0x0000032d5d8f content::ShellMainDelegate::RunProcess()
#17 0x0000023588fb content::ContentMainRunnerImpl::Run()
#18 0x0000047a02fb service_manager::Main()
#19 0x0000023572b1 content::ContentMain()
#20 0x00000328c90c content::BrowserTestBase::SetUp()
#21 0x00000328282f content::ContentBrowserTest::SetUp()
#22 0x00000217906d testing::Test::Run()
#23 0x000002179cd0 testing::TestInfo::Run()
#24 0x00000217a1e7 testing::TestCase::Run()
#25 0x000002185ae7 testing::internal::UnitTestImpl::RunAllTests()
#26 0x00000218565d testing::UnitTest::Run()
#27 0x0000032bb0e1 base::TestSuite::Run()
#28 0x000003286377 content::ContentTestLauncherDelegate::RunTestSuite()
#29 0x0000032a5874 content::LaunchTests()
#30 0x000003286330 main
#31 0x7f7de9a50f45 __libc_start_main
#32 0x00000137802a _start
Labels: OS-Linux Type-Bug-Regression
The tests are already disabled on ASAN (issue 871770) and Android (issue 872631). 

 Issue 873072  has been merged into this issue.
Cc: chiniforooshan@chromium.org
Owner: oysteine@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f616c54c91dbf061d4c13b54155d1884320e111e

commit f616c54c91dbf061d4c13b54155d1884320e111e
Author: vitaliii <vitaliii@chromium.org>
Date: Fri Aug 10 08:50:34 2018

Disable some TracingControllerTest on Linux, because flaky.

TracingControllerTest.DoubleStopTracing
TracingControllerTest.EnableAndStopTracingWithEmptyFile

TBR=oysteine@chromium.org

Bug:  873073 
Change-Id: I1455984cf656abb30f700cdf30c5a9f770971b16
Reviewed-on: https://chromium-review.googlesource.com/1170683
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582094}
[modify] https://crrev.com/f616c54c91dbf061d4c13b54155d1884320e111e/content/browser/tracing/tracing_controller_browsertest.cc

Labels: -Sheriff-Chromium
Please have a look at reenable, thank you!
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5b331e930a78935f8f981598e5f2383d7108446

commit c5b331e930a78935f8f981598e5f2383d7108446
Author: Oystein Eftevaag <oysteine@google.com>
Date: Tue Aug 14 00:03:54 2018

Perfetto: Start tracing as soon as the Consumer endpoint is created

Previously this was done in the OnConnect() callback, but it turns
out this is called via PostTask() so if tracing gets disabled immediately
after it's enabled, the disable call can come in between and causes
test failures due to the StopAndFlush callback never happening.

Bug:  873073 ,872631
Change-Id: I343060c5e4b9d66575e6b8fe71a28cc9b706a429
Reviewed-on: https://chromium-review.googlesource.com/1171658
Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582758}
[modify] https://crrev.com/c5b331e930a78935f8f981598e5f2383d7108446/content/browser/tracing/tracing_controller_browsertest.cc
[modify] https://crrev.com/c5b331e930a78935f8f981598e5f2383d7108446/services/tracing/perfetto/json_trace_exporter.cc

Status: Fixed (was: Assigned)

Sign in to add a comment