Hey just to clarify what you mean here: are you referring to the fact that with tabbing focus starts on "Upload an image"?

Hi @yyushkina,

Yes, the reporter here is referring to the issue that the tab focus starts from "Upload an image" option instead of 'Chrome backgrounds'.

Thank you..!

The first menu item can be disabled if the user is offline, but 'Upload an image' is always available, so it is selected for default focus. I agree it would be nicer if the first item is tabbed to first.

Weilun - can you take a look? The easiest way to simulate offline mode is in the Network tab of Developer tools, where there's an 'Offline' checkbox.

So the real problem for this bug is, the first option(custom background for online, upload image for offline) is already selected by default but it's not showing the focus ring because you are using mouse nav mode. Then, if you use any arrow key or tab, you will go to the next option wrt the key you hit. Should I only fix the tab key to make it focus on the first option or all keys?

Ah I see. So really this is actually the right behavior. We don't want to show visual focus if the user is using mouse nav. I think this is a "won't fix".

I can fix it by checking if it is the mouse nav mode or not. If it is then I focus the first option. If it is already in keyboard nav mode, then go to the next option. The question is do we want to do that?

Ah I see. That could work. So basically: so to recap if the user enters the gear through mouse nav, and then switches to keyboard and presses tab or down key then we focus the first option rather than the second (maybe also consider doing this if a user presses enter but make sure it doesn't "flicker"). Can you make sure this doesn't introduce any visible latency? I don't think it's worth doing if it does.

For me as least, there isn't any visible latency with the change. Please see the screenshot from both the gLinux and the MacOS.

Screencast:
gLinux: https://screencast.googleplex.com/cast/NTY0MTM4MTM4NTA3NjczNnxkMzNkOTFjNS01NA
MacOS: https://screencast.googleplex.com/cast/NDg0Mjg2MTcwMjkzODYyNHxiOWMzMDEzMC1kNg

Looks good!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdf5fa71178384ea4f58bb9bc9bcc9399c3b8548

commit cdf5fa71178384ea4f58bb9bc9bcc9399c3b8548
Author: Weilun Shi <sweilun@chromium.org>
Date: Wed Aug 15 19:08:01 2018

[NTP] When using tab on edit dialog, focus on first available option

Fixing the focusing issue when mixing up both keyboard navigation mode
and mouse navigation mode. Focus on the first available option when we
are on the mouse navigation mode but use tab or arrow key at the first
time.

Bug:  873071 
Change-Id: I0a18ac3a92bff9eafef5788b4ced5755d4fa196e
Reviewed-on: https://chromium-review.googlesource.com/1173754
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583347}
[modify] https://crrev.com/cdf5fa71178384ea4f58bb9bc9bcc9399c3b8548/chrome/browser/resources/local_ntp/custom_backgrounds.js

Update:
 Rechecked above issue on Win(7,8,8.1,10) , Linux(14.04 LTS) and Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14) using latest canary build #70.0.3524.0 and issue is fixed.

please refer attached screencast for reference.

Thank You. 

Deleted: Canary_behaviour.mp4 1.6 MB

	Canary_behaviour.mp4 1.6 MB View Download