New issue
Advanced search Search tips

Issue 873068 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

CRAS crash at create_dummy_ini

Project Member Reported by hychao@chromium.org, Aug 10

Issue description

https://crash.corp.google.com/7723c23e05ac794a

0xae136b36	(libc-2.23.so + 0x00016b36 )	__libc_do_syscall
0xae1455b1	(libc-2.23.so -raise.c:54 )	raise
0xae146379	(libc-2.23.so -abort.c:89 )	abort
0xae16df39	(libc-2.23.so -libc_fatal.c:175 )	__libc_message
0xae1c3b33	(libc-2.23.so -fortify_fail.c:30 )	__fortify_fail
0xae1c3b09	(libc-2.23.so -stack_chk_fail.c:28 )	__stack_chk_fail
0x0f325e4f	(cras -cras_dsp_ini.c:363 )	create_dummy_ini
0x0f325923	(cras -cras_dsp.c:199 )	cras_dsp_load_dummy_pipeline
0x0f32a54f	(cras -cras_iodev.c:524 )	add_ext_dsp_module_to_pipeline
0x0f32ac93	(cras -cras_iodev.c:932 )	cras_iodev_open
0x0f32bc05	(cras -cras_iodev_list.c:451 )	stream_added_cb
0x0f3342f3	(cras -stream_list.c:88 )	stream_list_add
0x0f32f339	(cras -cras_rclient.c:73 )	handle_client_stream_connect
0x0f32ee65	(cras -cras_rclient.c:473 )	cras_rclient_message_from_client
0x0f32ed99	(cras -cras_rclient.c:407 )	cras_rclient_buffer_from_client
0x0f316da9	(cras -cras_server.c:126 )	cras_server_run
0x0f31678f	(cras -cras.c:141 )	main
0xae13689f	(libc-2.23.so -libc-start.c:289 )	__libc_start_main
0x0f316493	(cras + 0x00005493 )	_start
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/1ea22fdc4ee20aebd04084f4f48ede5520fbb14b

commit 1ea22fdc4ee20aebd04084f4f48ede5520fbb14b
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Sat Aug 11 20:14:55 2018

CRAS: dsp_ini - Fix crash when creating dummy dsp ini

Sets the max allowed number of channels to 8.
Fix the incorrect array size.

BUG= chromium:873068 
TEST=Test basic playback and capture.

Change-Id: Id545b11863a882ac5c37e4c9a792bac014e11754
Reviewed-on: https://chromium-review.googlesource.com/1170662
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/1ea22fdc4ee20aebd04084f4f48ede5520fbb14b/cras/src/server/cras_dsp_ini.c

Cc: cindyb@chromium.org
Labels: M-69 Merge-Request-69
request merge to M69
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 14

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-69 Merge-Approved-69
Merge approved, M69.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 16

Labels: merge-merged-release-R69-10895.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/3f1d3e4ed84c3d6102d0090f4f028e9862d3c19b

commit 3f1d3e4ed84c3d6102d0090f4f028e9862d3c19b
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Thu Aug 16 03:23:15 2018

CRAS: dsp_ini - Fix crash when creating dummy dsp ini

Sets the max allowed number of channels to 8.
Fix the incorrect array size.

BUG= chromium:873068 
TEST=Test basic playback and capture.

Change-Id: Id545b11863a882ac5c37e4c9a792bac014e11754
Reviewed-on: https://chromium-review.googlesource.com/1170662
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
(cherry picked from commit 1ea22fdc4ee20aebd04084f4f48ede5520fbb14b)
Reviewed-on: https://chromium-review.googlesource.com/1176899
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Commit-Queue: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/3f1d3e4ed84c3d6102d0090f4f028e9862d3c19b/cras/src/server/cras_dsp_ini.c

Status: Fixed (was: Started)
Labels: -Merge-Approved-69

Sign in to add a comment