The IdentityChooser is using an MDC presentation. It should have something closer to what we do for UI Refresh, for example the tools menu.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc1903346f6ad06545e9c3d63a94b2e8e3fb034c commit bc1903346f6ad06545e9c3d63a94b2e8e3fb034c Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Aug 13 08:42:47 2018 [iOS] Create CustomPresentation for the IdentityChooser The Identity Chooser popup was using the MDC presentation style. It is not in line with the current style applied with UI Refresh. This CL creates the classes to be user to present the popup according to the new styling. For now, no animation or styling is done. Bug: 873065 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I73b93e0d47c7ebe2e2b5756faaf6fea32be63b3e Reviewed-on: https://chromium-review.googlesource.com/1169815 Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#582530} [modify] https://crrev.com/bc1903346f6ad06545e9c3d63a94b2e8e3fb034c/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/BUILD.gn [add] https://crrev.com/bc1903346f6ad06545e9c3d63a94b2e8e3fb034c/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_animator.h [add] https://crrev.com/bc1903346f6ad06545e9c3d63a94b2e8e3fb034c/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_animator.mm [add] https://crrev.com/bc1903346f6ad06545e9c3d63a94b2e8e3fb034c/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_presentation_controller.h [add] https://crrev.com/bc1903346f6ad06545e9c3d63a94b2e8e3fb034c/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_presentation_controller.mm [add] https://crrev.com/bc1903346f6ad06545e9c3d63a94b2e8e3fb034c/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_transition_delegate.h [add] https://crrev.com/bc1903346f6ad06545e9c3d63a94b2e8e3fb034c/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_transition_delegate.mm [modify] https://crrev.com/bc1903346f6ad06545e9c3d63a94b2e8e3fb034c/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38bdfc75a85144d3e7dba1100d92db0046a4f033 commit 38bdfc75a85144d3e7dba1100d92db0046a4f033 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Aug 13 09:13:54 2018 [iOS] Add IdentityChooser presentation animations This CL adds the animations for the presentation of the IdentityChooser. Bug: 873065 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id64905a5e11fcf64ed65860aabf988a01e17d837 Reviewed-on: https://chromium-review.googlesource.com/1170774 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#582536} [modify] https://crrev.com/38bdfc75a85144d3e7dba1100d92db0046a4f033/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/BUILD.gn [modify] https://crrev.com/38bdfc75a85144d3e7dba1100d92db0046a4f033/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_animator.h [modify] https://crrev.com/38bdfc75a85144d3e7dba1100d92db0046a4f033/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_animator.mm [modify] https://crrev.com/38bdfc75a85144d3e7dba1100d92db0046a4f033/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_coordinator.h [modify] https://crrev.com/38bdfc75a85144d3e7dba1100d92db0046a4f033/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_coordinator.mm [modify] https://crrev.com/38bdfc75a85144d3e7dba1100d92db0046a4f033/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_presentation_controller.mm [modify] https://crrev.com/38bdfc75a85144d3e7dba1100d92db0046a4f033/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_transition_delegate.h [modify] https://crrev.com/38bdfc75a85144d3e7dba1100d92db0046a4f033/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_transition_delegate.mm [modify] https://crrev.com/38bdfc75a85144d3e7dba1100d92db0046a4f033/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_view_controller.h [modify] https://crrev.com/38bdfc75a85144d3e7dba1100d92db0046a4f033/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_view_controller.mm [modify] https://crrev.com/38bdfc75a85144d3e7dba1100d92db0046a4f033/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_coordinator.mm [modify] https://crrev.com/38bdfc75a85144d3e7dba1100d92db0046a4f033/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.h [modify] https://crrev.com/38bdfc75a85144d3e7dba1100d92db0046a4f033/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.mm
Issue 853215 has been merged into this issue.
Comment 1 by bugdroid1@chromium.org
, Aug 13