Issue metadata
Sign in to add a comment
|
Regression: Focus ring on close(x) icon is seen oval in shape.
Reported by
sanyam.g...@etouch.net,
Aug 10
|
||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3517.0 (Official Build)Revision 40b8dc74d4eba316ce85e7c7cb5cac598d17069d-refs/branch-heads/3517@{#1}(32/64-bit) OS: Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) Pre-condition: Enable 'Use Views browser windows instead of Cocoa' from chrome://flags. What steps will reproduce the problem? (1) Launch chrome and navigate to NTP. (2) Press 'Tab' key to bring focus on close(x) icon of a tab and observe the focus ring. Actual Result : Focus ring on close(x) icon is seen oval in shape. Expected Result: Focus ring on close(x) icon should be seen round not oval in shape. This is a regression issue, broken in 'M70', below is per-revision bisect info: Good Build:70.0.3516.0(Revision: 581410) Bad Build: 70.0.3517.0(Revision: 581729) You are probably looking for a change made after 581552 (known good), but no later than 581553 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/46b03fcf88a29480afce6f0209cd17d872afa8e1..52e71c0e747870b84336ee33ba1c27fff5aafbcd Suspect: https://chromium.googlesource.com/chromium/src/+/52e71c0e747870b84336ee33ba1c27fff5aafbcd @kylixrd: Could you please help to reassign if your change is not the cause for this change. Note: Above issue is not seen on Windows(7,8,8.1)and Linux(14.04 LTS) OS. Kindly review the attached screen-cast for reference. Thank You..!!
,
Aug 10
Probably without containing the icon the button got slightly shorter in height or something. I'd imagine this would affect the hit test region too.
,
Aug 13
I went to root-cause this and ended up just fixing it: https://chromium-review.googlesource.com/c/chromium/src/+/1172506
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1278dfb9260d39986b949151ecd84a333fb2019a commit 1278dfb9260d39986b949151ecd84a333fb2019a Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Aug 14 14:02:38 2018 views: make TabCloseButton a square Without any stored images, TabCloseButton falls back to the default sizing for ImageButton, which is 16x14. This change makes it always a square, which makes the focus ring and ink drop circles instead of ovals. Bug: 873063 Change-Id: I5c2deec54f768d64be14ee0f9c0adcb52a8d754e Reviewed-on: https://chromium-review.googlesource.com/1172506 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#582903} [modify] https://crrev.com/1278dfb9260d39986b949151ecd84a333fb2019a/chrome/browser/ui/views/tabs/tab_close_button.cc [modify] https://crrev.com/1278dfb9260d39986b949151ecd84a333fb2019a/chrome/browser/ui/views/tabs/tab_close_button.h
,
Aug 14
,
Aug 14
Yes, if we merge that we need to merge this.
,
Aug 14
Cl listed at #5 landed 3 hrs back, not in canary yet. Pls update the bug with canary result tomorrow. Thank you.
,
Aug 15
The NextAction date has arrived: 2018-08-15
,
Aug 15
70.0.3523.0 has the fix & shows the correct behavior.
,
Aug 15
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 15
Approving merge to M69 branch 3497 based on comment #10. Please merge before 1:00 PM PT today so we can pick it up for tomorrow's Beta release. Thank you.
,
Aug 15
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d880d8efe1bfe1204790a7bdf34674f374ffcb4d commit d880d8efe1bfe1204790a7bdf34674f374ffcb4d Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Aug 15 15:02:34 2018 views: make TabCloseButton a square Without any stored images, TabCloseButton falls back to the default sizing for ImageButton, which is 16x14. This change makes it always a square, which makes the focus ring and ink drop circles instead of ovals. Bug: 873063 Change-Id: I5c2deec54f768d64be14ee0f9c0adcb52a8d754e Reviewed-on: https://chromium-review.googlesource.com/1172506 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#582903}(cherry picked from commit 1278dfb9260d39986b949151ecd84a333fb2019a) Reviewed-on: https://chromium-review.googlesource.com/1175862 Cr-Commit-Position: refs/branch-heads/3497@{#636} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/d880d8efe1bfe1204790a7bdf34674f374ffcb4d/chrome/browser/ui/views/tabs/tab_close_button.cc [modify] https://crrev.com/d880d8efe1bfe1204790a7bdf34674f374ffcb4d/chrome/browser/ui/views/tabs/tab_close_button.h
,
Aug 16
Update: Rechecked the above issue on Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) OS using latest canary #70.0.3524.0 and beta build #69.0.3497.42 and issue is fixed, hence adding TE-Verified labels. Kindly refer the attached screen-cast for reference. Thank You.! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pkasting@chromium.org
, Aug 10