New issue
Advanced search Search tips

Issue 873051 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Abrt in SkRegion::setRect

Project Member Reported by ClusterFuzz, Aug 10

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6685007255699456

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x053900000001
Crash State:
  SkRegion::setRect
  SkRegion::setRect
  SkRegion::SkRegion
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=549084:549085

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6685007255699456

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 10

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Aug 10

Labels: Test-Predator-Auto-Owner
Owner: halcanary@google.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://skia.googlesource.com/skia/+/c5a1c1f92f67c3f2b54250d040d3d3cd51e2feb7 (SkRegion: Use less memory for SkRegion::Oper).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Status: Started (was: Assigned)
https://review.skia.org/147041

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/1b95ef9f99121f3978cfc9db4be1ed8255decc93

commit 1b95ef9f99121f3978cfc9db4be1ed8255decc93
Author: Hal Canary <halcanary@google.com>
Date: Mon Aug 13 19:57:18 2018

SkRegion: Do not assume good input.

BUG= chromium:873051 

Change-Id: I2b84bade333e101fade81994203640ddf724f550
Reviewed-on: https://skia-review.googlesource.com/147041
Auto-Submit: Hal Canary <halcanary@google.com>
Commit-Queue: Cary Clark <caryclark@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>

[modify] https://crrev.com/1b95ef9f99121f3978cfc9db4be1ed8255decc93/src/core/SkRegion.cpp
[modify] https://crrev.com/1b95ef9f99121f3978cfc9db4be1ed8255decc93/tests/RegionTest.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b080c398f21c196f7e37be542c59ac0aae4f488

commit 2b080c398f21c196f7e37be542c59ac0aae4f488
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Aug 14 01:27:47 2018

Roll src/third_party/skia b35c655378ee..1b95ef9f9912 (7 commits)

https://skia.googlesource.com/skia.git/+log/b35c655378ee..1b95ef9f9912


git log b35c655378ee..1b95ef9f9912 --date=short --no-merges --format='%ad %ae %s'
2018-08-13 halcanary@google.com SkRegion: Do not assume good input.
2018-08-13 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader c47cd435bf6f..378c434627aa (1 commits)
2018-08-13 mtklein@google.com use legal FirstDirection as kDontCheck sentinel
2018-08-13 mtklein@google.com avoid illegal enum values in PathTest
2018-08-13 scroggo@google.com SkCodec: Always use 0 for filling
2018-08-13 csmartdalton@google.com Add unit tests for src=dst in SkGeometry
2018-08-13 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 a43d7306d87a..35bc74d6d139 (2 commits)


Created with:
  gclient setdep -r src/third_party/skia@1b95ef9f9912

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:873051 
TBR=kjlubick@chromium.org

Change-Id: Iacdce503576c981ad1f75493dd71f9f91672d8ee
Reviewed-on: https://chromium-review.googlesource.com/1173172
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582785}
[modify] https://crrev.com/2b080c398f21c196f7e37be542c59ac0aae4f488/DEPS

Project Member

Comment 6 by ClusterFuzz, Aug 14

ClusterFuzz has detected this issue as fixed in range 582783:582789.

Detailed report: https://clusterfuzz.com/testcase?key=6685007255699456

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x053900000001
Crash State:
  SkRegion::setRect
  SkRegion::setRect
  SkRegion::SkRegion
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=549084:549085
Fixed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=582783:582789

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6685007255699456

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Aug 14

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6685007255699456 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment