New issue
Advanced search Search tips

Issue 873003 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 853841



Sign in to add a comment

Frame color shows through tabs with strokes

Project Member Reported by thomasanderson@chromium.org, Aug 10

Issue description

See the attached image.  There's a very thin green fringe between the stroke and the active tab.
 
Screenshot from 2018-08-09 17-49-56 (copy).png
9.1 KB View Download
If we're computing the stroke as (outer border - inner border), then presumably this is due to precision loss in Skia that we can't do much about but also wouldn't be visible at non-extreme scales.
Yeah I was thinking the same thing.  But it might be fixable after I land the patch that draws opaque stroke colors.  We would just need to pass 0.5*stroke_thickness to GetInteriorPath().
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6044ebe19878468f70a22d15dbef7b7987f25bf5

commit 6044ebe19878468f70a22d15dbef7b7987f25bf5
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Aug 14 02:26:16 2018

[Refresh] Fix frame color showing through tabs with strokes

BUG= 873003 
R=pkasting

Change-Id: I9f2550b32a94c143f443bcb7e0762bd9dde6f7ee
Reviewed-on: https://chromium-review.googlesource.com/1173652
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582801}
[modify] https://crrev.com/6044ebe19878468f70a22d15dbef7b7987f25bf5/chrome/browser/ui/views/tabs/tab.cc

Status: Fixed (was: Assigned)

Sign in to add a comment