monochrome_public_bundle apkbuilder.py failing on android_arm64_dbg_recipe CQ bot |
||||
Issue descriptionMany failed compiles on https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android_arm64_dbg_recipe?limit=200 Nearly all of them appear to fail at creating "gen/chrome/android/monochrome_public_bundle/base.zip". Failure looks like: Traceback (most recent call last): File "../../build/android/gyp/apkbuilder.py", line 420, in <module> main(sys.argv[1:]) File "../../build/android/gyp/apkbuilder.py", line 416, in main add_pydeps=False) File "/b/swarming/w/ir/cache/builder/src/build/android/gyp/util/build_utils.py", line 602, in CallAndWriteDepfileIfStale pass_changes=True) File "/b/swarming/w/ir/cache/builder/src/build/android/gyp/util/md5_check.py", line 63, in CallAndRecordIfStale new_metadata.AddFile(path, _Md5ForPath(path)) File "/b/swarming/w/ir/cache/builder/src/build/android/gyp/util/md5_check.py", line 381, in _Md5ForPath _UpdateMd5ForFile(md5, path) File "/b/swarming/w/ir/cache/builder/src/build/android/gyp/util/md5_check.py", line 362, in _UpdateMd5ForFile with open(path, 'rb') as infile: IOError: [Errno 2] No such file or directory: u'android_clang_arm/libmonochrome.cr.so' Always due to a missing *.so. Is there a race condition in the build somewhere where we're trying to package up a lib before it gets built? Crawling through src/build/ changes doesn't really show anything culpable. See example failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android_arm64_dbg_recipe/91447 https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android_arm64_dbg_recipe/91435 https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android_arm64_dbg_recipe/91419 https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android_arm64_dbg_recipe/91411
,
Aug 10
Issue 873050 has been merged into this issue.
,
Aug 10
,
Aug 10
I think the problem is that bundle modules don't depend on the secondary ABI libraries. So, if we are lucky, Monochrome APK gets built first and creates all secondary ABI libraries. However, if the monochrome base bundle module gets built first the secondary ABI libs don't exist yet. I'm fixing this in https://chromium-review.googlesource.com/c/chromium/src/+/1165533.
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8217643ea828e42c6dfd966b3d7d6d56df2a0d37 commit 8217643ea828e42c6dfd966b3d7d6d56df2a0d37 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Fri Aug 10 19:00:52 2018 [build] Fix build of Monochrome base module Make bundle modules depend on the secondary ABI libraries. This should fix a build race condition where we fail if we build the Monochrome bundle module before the APK. Bug: 872998 Change-Id: I756b779ac390e806666f398e00936df29f93cdaf Reviewed-on: https://chromium-review.googlesource.com/1171217 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#582277} [modify] https://crrev.com/8217643ea828e42c6dfd966b3d7d6d56df2a0d37/build/config/android/rules.gni
,
Aug 10
Hopefully, this is fixed now.
,
Aug 10
Looks like it. Those failures are disappearing from the bot now, thnx! |
||||
►
Sign in to add a comment |
||||
Comment 1 by bpastene@chromium.org
, Aug 10