New issue
Advanced search Search tips

Issue 872991 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

Cookies dialog bottom cut off on very small screens

Project Member Reported by leberly@chromium.org, Aug 10

Issue description

70.0.3514.0 (Official Build) dev (64-bit) (cohort: Dev)
Windows 10

To get this dialog, go to the security chip in any page (left of the Omnnibox text) and select "Cookies." 

Go to Windows Settings > Display > Scale and Layout and adjust to 175%.
Expected: able to use tab or scroll to get to the bottom of the dialog
Actual: unable to reach bottom of dialog at all

Please see screenshot. More and more Windows is making >100% scaling the default. 


 
cookiesDialog.png
39.3 KB View Download
Labels: a11y-Omnibox
Components: UI>Browser>Omnibox>SecurityIndicators
Owner: cthomp@chromium.org
Status: Assigned (was: Available)
cthomp: assigning to you based on reference in go/estark-on-leave.
Components: -UI>Browser>Omnibox>SecurityIndicators UI>Browser>SiteSettings
This looks like an issue with CollectedCookiesView [1], not the security indicator, so adjusting components.

I'm also curious if this can happen with other WebModalDialogViews (this gets created through [2] and [3] -- what else is the same and could be long enough to trigger this on text scaling?). 

[1] https://cs.chromium.org/chromium/src/chrome/browser/ui/views/collected_cookies_views.h?dr=CSs&g=0&l=39
[2] https://cs.chromium.org/chromium/src/components/constrained_window/constrained_window_views.cc?l=186&gsn=ShowWebModalDialogViews
[3] https://cs.chromium.org/chromium/src/components/constrained_window/constrained_window_views.cc?l=220&gsn=CreateWebModalDialogViews
Cc: msw@chromium.org cthomp@chromium.org
Components: Internals>Views
Owner: ----
Status: Available (was: Assigned)
Removing myself as owner as I don't think I'm the right person to own this (since I think the cause is higher up the stack in views or components/constrainted_window.

+msw@ for more thoughts on whether this involves constrained_window.
Components: -UI>Accessibility UI>HighDPI
Status: Untriaged (was: Available)
It's hard to tell what's happening in that screenshot, is the dialog taller than the display?
I'm not working on ui surface issues like this currently, and I'm not sure who is.
Labels: Hotlist-DesktopUIConsider
Labels: Group-Dialogs
Labels: -Hotlist-DesktopUIConsider Hotlist-DesktopUITriaged
Owner: dfried@chromium.org
Status: Assigned (was: Untriaged)
Routing to dfried@ for secondary UI.
Labels: Target-73 M-73
Owner: ----
Status: Available (was: Assigned)
Cc: viswa.karala@chromium.org
 Issue 901615  has been merged into this issue.
Owner: dfried@chromium.org
Status: Started (was: Available)
Cc: dfried@chromium.org
Components: -UI>HighDPI
Owner: markchang@chromium.org
Status: Untriaged (was: Started)
Summary: Cookies dialog bottom cut off on very small screens (was: Cookies dialog unable to respect Windows text scaling; bottom cut off)
This is a dialog we're considering re-engineering (and have been for some time). Currently, the cookies dialog works as follows:
 1. Parented to the main browser window
 2. Clipped by the main browser window
 3. Modal to the current tab (current tab is frozen until it's closed)
 4. Only visible when the current tab is active
 5. Closes if the current tab navigates

The real problem is (2) above - because it's not a separate, free-floating window, if the browser window is too small to hold it, the bottom gets cut off. This should only be an issue when the browser is smaller than about 650 DIP tall in a maximized browser window.

So the solution for people whose dialog is cut off is to make the browser window larger. If they're operating on a screen that's less than 675 DIP tall, then there is a potential problem, but my understanding is that screens smaller than 1024x768 DIPs probably aren't high priority for us to support.

That said, if PM/UX decide it's worth pursuing, we could probably shave some height off of the window to make it work in maximized browser windows that are 600 DIP tall (but would require a redesign of the Cookies dialog, with less vertical whitespace).

The alternative would be to create a whole new modality for dialogs just for this one, which has all the properties of a web contents-modal dialog but can float outside the current browser window. This also still wouldn't fix the problem of too-small screens cutting off the bottom of the dialog, though.

One thing we *can't* do is just add a close button to the top, since cutting off the buttons at the bottom effectively still makes the dialog unusable, and it's not clear what the correct behavior on clicking [X] would even be.

I'm bouncing this back to PM for triage with this additional information. Hopefully we can make a decision about what avenue to pursue.
Status: Assigned (was: Untriaged)

Sign in to add a comment