New issue
Advanced search Search tips

Issue 872980 link

Starred by 2 users
Status: Fixed
Owner:
thestig@chromium.org
Closed: Aug 14
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

DCHECK failure in PrintRenderFrameHelper::PrintPreviewContext.

Project Member Reported by thestig@chromium.org, Aug 9 
This is split off from bug 872935. Following the repro steps in that bug report with a debug build, I get a DCHECK failure in PrintRenderFrameHelper::PrintPreviewContext::Failed():

[1:1:0809/142306.191201:FATAL:print_render_frame_helper.cc(2309)] Check failed: state_ == INITIALIZED || state_ == RENDERING.

|state_| is DONE in this case, since the failure happened in PrintRenderFrameHelper::FinalizePrintReadyDocument().
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b9251fa6751d27eecc662dfc9a142943883bc3f

commit 7b9251fa6751d27eecc662dfc9a142943883bc3f
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Aug 14 01:03:16 2018

Fix DCHECK failure in PrintRenderFrameHelper::PrintPreviewContext.

Accept the "DONE" state as a valid state for failing, since after the
rendering is done, there is still work to do and that work can
potentially fail.

BUG= 872980 

Change-Id: If1eb31c57057b2e6354dc4649ec7806468fa3f1d
Reviewed-on: https://chromium-review.googlesource.com/1170199
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582775}
[modify] https://crrev.com/7b9251fa6751d27eecc662dfc9a142943883bc3f/components/printing/renderer/print_render_frame_helper.cc

Comment 2 by thestig@chromium.org, Aug 14

Status: Fixed (was: Assigned)
►

Sign in to add a comment