New issue
Advanced search Search tips

Issue 872972 link

Starred by 1 user
Status: Fixed
Owner:
f...@opera.com
Closed: Aug 15
Cc:
robertma@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

[WPT] New failures introduced in external/wpt/svg by import https://crrev.com/c/1169943

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Aug 9 
WPT import https://crrev.com/c/1169943 introduced new failures in external/wpt/svg:

List of new failures:
external/wpt/svg/painting/reftests/paint-order-001.svg [ Failure ]

This import contains upstream changes from db70f9499d3902580ce07c63ac131217c3619468 to 0e1ac363581d4bf0851a00a5563619bfef622fe4:
Replace document.origin with self.origin in cookie-helper.sub.js (#12377): https://github.com/web-platform-tests/wpt/commit/0e1ac363581d4bf0851a00a5563619bfef622fe4
 [testharness.js] Honor promises from cleanup fns  (#8748): https://github.com/web-platform-tests/wpt/commit/f8ff0b704c6628f5c7da7a01657485e29678fc1a
HTML: More event listener tests for document open steps: https://github.com/web-platform-tests/wpt/commit/dc0ec8ee874c2b2abf5a5e73907ddcdf27575432
HTML: Use /common/blank.html in document open steps tests: https://github.com/web-platform-tests/wpt/commit/3faeaa9350a80436a52e54708ec5b642c81ea380
HTML: Add checks for the return value of document.open(): https://github.com/web-platform-tests/wpt/commit/ea85edd7e7db3a08088a5951b881a83380f07154
Ensure the ls-tree/check-ignore pairing use the same separators.: https://github.com/web-platform-tests/wpt/commit/f4599d6f628d811be4bdee2cd927e2e50ad294a2
Merge pull request #10914 from Tavmjong/paint-order: https://github.com/web-platform-tests/wpt/commit/9c84759a72f2b427160b8656bf31fe7c756c459e
Wrap an assert in step_func in a CSP test (#12305): https://github.com/web-platform-tests/wpt/commit/590992ecaa850723c3300417912a874d94295444
Remove unneeded test meta data.: https://github.com/web-platform-tests/wpt/commit/d299fd34e85ca8e0f22e292dd65534411682de70 [affecting this directory]
Fix lint issues.: https://github.com/web-platform-tests/wpt/commit/1371fb01d8e8e5e443781e786d8da2aade15e76a [affecting this directory]
Add basic paint order test ('paint-order').: https://github.com/web-platform-tests/wpt/commit/f089b6c96cc94d5c82f265e55e8ef6ab2d609f7d [affecting this directory]

Comment 1 by schenney@chromium.org, Aug 10

Owner: schenney@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by f...@opera.com, Aug 13 

Looks like the test has a bug? @schenney, if you don't have a fix in progress I can handle this.

Comment 3 by schenney@chromium.org, Aug 13

Owner: f...@opera.com
I'm not actively looking at it. Thanks.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/042919888010b41fda182356bf27c4fa2cb15f71

commit 042919888010b41fda182356bf27c4fa2cb15f71
Author: Fredrik Söderquist <fs@opera.com>
Date: Tue Aug 14 14:59:29 2018

Fix ref for external/wpt/svg/painting/reftests/paint-order-001.svg

The property:

  paint-order: stroke markers

is equivalent to:

  paint-order: stroke markers fill

(Spec: "If any of the three keywords are omitted, they are painted last,
 in the order they would be painted with paint-order: normal."
 @ https://svgwg.org/svg2-draft/painting.html#PaintOrder )

So the fill should be painted last. Add 'marker:none' to the appropriate
element in the ref.

Disable stroke and marker in a few cases to avoid "overdraw" and thus
"incorrect" edge rendering in some cases.

BUG= 872972 

Change-Id: I835a6980fa069825ed2a2e920862018faec6d93c
Reviewed-on: https://chromium-review.googlesource.com/1172778
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#582914}
[modify] https://crrev.com/042919888010b41fda182356bf27c4fa2cb15f71/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/042919888010b41fda182356bf27c4fa2cb15f71/third_party/WebKit/LayoutTests/external/wpt/svg/painting/reftests/paint-order-001-ref.svg

Comment 5 by f...@opera.com, Aug 15

Status: Fixed (was: Assigned)
►

Sign in to add a comment