New issue
Advanced search Search tips

Issue 872935 link

Starred by 3 users
Status: Assigned
Owner:
thestig@chromium.org
Cc:
halcanary@google.com
weili@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Print preview generation fails for a large document

Project Member Reported by thestig@chromium.org, Aug 9 
Chrome Version: r581818 developer build
OS: Linux

What steps will reproduce the problem?
(1) Open https://www.gmbinder.com/share/-LFhhtssjN-teWCOregn
(2) Print preview with the following settings:

Destination: Save as PDF
Paper size: A4

Leave other settings on default.

(3) Wait for the print preview to generate...

What is the expected result?

100+ page print preview appears.

What happens instead?

Print preview fails. In my debug build, I get:

[1:1:0809/142306.190923:ERROR:print_render_frame_helper.cc(1341)] CopyMetafileDataToReadOnlySharedMem failed
[1:1:0809/142306.191087:ERROR:print_render_frame_helper.cc(1624)] CreatePreviewDocument failed
[1:1:0809/142306.191201:FATAL:print_render_frame_helper.cc(2309)] Check failed: state_ == INITIALIZED || state_ == RENDERING. <-- this should be a separate issue.

This is split off from bug 871678. I bisected this to r546111, so it has to do with print compositing. Maybe the MSKP we are trying to send is too big?

Comment 1 by thestig@chromium.org, Aug 9 

In FinalizePrintReadyDocument(), it tries to send 2.6 GB of data.

Comment 2 by thestig@chromium.org, Aug 9

Cc: halcanary@chromium.org
Chrome 66 generates a 139 MB PDF. So presumably without compositing, it sends a lot less data over IPC.

Comment 3 by thestig@chromium.org, Aug 9 

BTW, I filed  bug 872980  and  bug 872983  for some of the bad failure handling issues I found.

Comment 4 by thestig@chromium.org, Nov 2

Owner: thestig@chromium.org
Status: Assigned (was: Available)
We can fix this if the compositor accumulates data for the "print ready" document instead of the renderer.

Comment 5 by ryurag...@gmail.com, Dec 5 

Any updates on this?

Comment 6 by thestig@chromium.org, Dec 5 

I prototyped a fix last month, but haven't gotten around to making it good enough to check in yet.

Comment 7 by ryurag...@gmail.com, Dec 7 

Fair enough. May have to use a standalone version of v60.0.3112.113-r474897-win64, as I have tested versions prior to this particular version, and they had issues to GMBinder, as I have posted in https://bugs.chromium.org/p/chromium/issues/detail?id=871678#c19.

Whereas v60.0.3112.113-r474897-win64 is the first released version that seems to work with GMBinder's content. It appears to render correctly, fast, and most of all, doesn't fail to load print preview.

Comment 8 by halcanary@google.com, Today (15 hours ago)

Cc: -halcanary@chromium.org halcanary@google.com
►

Sign in to add a comment