New issue
Advanced search Search tips

Issue 872928 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 14
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Tricium not triggering for new patchsets

Project Member Reported by juliehockett@google.com, Aug 9

Issue description

On uploading new patches, Tricium should be triggered within a few seconds. The following never triggered it:

https://chromium-review.googlesource.com/c/playground/gerrit-tricium/+/1169970

https://chromium-review.googlesource.com/c/playground/gerrit-tricium/+/1169946 (patchsets 2 and 3)
 
Labels: -Pri-3 Pri-1
Owner: qyears...@chromium.org
Status: Assigned (was: Untriaged)
In launch request logs:
[launcher] Failed to call Launcher.Launch :: {"error":"rpc error: code = Unknown desc = failed to generate workflow config for project \"playground-gerrit-tricium\": failed to create worker: failed to unmarshal: unexpected end of JSON input"}

Now checking why this may be; the service config was just modified to include the first definition for a recipe-based analyzer; the config itself looked OK to me, so I think the config itself is valid.
Owner: juliehockett@google.com
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/infra/infra/+/1170099
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d1c5622088fc3fecbc3174baa746034e67ef93c8

commit d1c5622088fc3fecbc3174baa746034e67ef93c8
Author: Julie Hockett <juliehockett@google.com>
Date: Thu Aug 09 23:17:55 2018

[tricium] Fix for error in parsing configs

Go's json.Unmarshal errors on the empty string, so this patch checks for
that and skips if the recipe analyzer's properties are not defined.

Bug:  872928 
Change-Id: I17a315f0a1ca14379ff8200ca1c7350fe8d1b3b6
Reviewed-on: https://chromium-review.googlesource.com/1170099
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Julie Hockett <juliehockett@google.com>

[modify] https://crrev.com/d1c5622088fc3fecbc3174baa746034e67ef93c8/go/src/infra/tricium/appengine/common/config/generate_test.go
[modify] https://crrev.com/d1c5622088fc3fecbc3174baa746034e67ef93c8/go/src/infra/tricium/appengine/common/config/generate.go

Status: Fixed (was: Started)

Sign in to add a comment