Remove "Learn more" link from payments sync toggle |
|||||||
Issue descriptionSee this thread for background: https://groups.google.com/a/google.com/forum/#!topic/project-unity/fHlf8c6cxDY. Let's remove the "Learn more" link from the "Payment methods and addresses using Google Pay" sync setting on desktop. Assigning to Durga to triage. Durga, could you please assign to the right Autofill/Payments engineer?
,
Sep 11
What's the timeline for this? M71?
,
Dec 10
,
Dec 17
This is not related to Payment Request and Payment Handler, so the correct component is UI>Browser>Autofill>UI. (Services>Sync may also be involved.)
,
Dec 17
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1887ffa2c51f39e928a4448476214aab8975fcd8 commit 1887ffa2c51f39e928a4448476214aab8975fcd8 Author: Sebastien Lalancette <seblalancette@chromium.org> Date: Mon Dec 17 20:17:22 2018 Removed "Learn more" link from payments sync toggle Tested locally by going to chrome://settings/syncSetup Added screenshot with the fix in the bug. Bug: 872921 Change-Id: Ifc3bab25da66afc3372318d9c4a9aecceb06c6f6 Reviewed-on: https://chromium-review.googlesource.com/c/1379355 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#617207} [modify] https://crrev.com/1887ffa2c51f39e928a4448476214aab8975fcd8/chrome/browser/resources/settings/people_page/sync_controls.html [modify] https://crrev.com/1887ffa2c51f39e928a4448476214aab8975fcd8/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/1887ffa2c51f39e928a4448476214aab8975fcd8/components/autofill/core/common/autofill_constants.cc [modify] https://crrev.com/1887ffa2c51f39e928a4448476214aab8975fcd8/components/autofill/core/common/autofill_constants.h
,
Dec 17
,
Dec 18
@Sebastien Lalancette: Could you please provide manual reproducible steps that reproduce the issue which helps us in verifying the issue. Thanks.
,
Dec 18
Sure, in Chrome you can go to: chrome://settings/syncSetup Depending on your Chrome version, you either see the options right away and you can validate, or you have to navigate down "Manage sync", and then you'll see the options.
,
Jan 8
Able to reproduce this issue on Mac 10.14.0, Windows 10 and Ubuntu 17.10 on the build without Fix 65.0.3318.0 and the issue is fixed on the latest M-73 build 73.0.3664.3. Steps: ----- 1. Launched Chrome 2. Navigated to chrome://settings/syncSetup Observed there is no "Learn more" link from payments sync toggle Attached is the screenshot for reference. Hence adding TE verified labels. Thanks..! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by durgapandey@chromium.org
, Sep 11