New issue
Advanced search Search tips

Issue 872919 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: ----
Type: ----


Participants' hotlists:
Launcher-Tech-Debt


Sign in to add a comment

Create the test api for LaserPointerWorksWithRemoteApp in M69

Project Member Reported by newcomer@chromium.org, Aug 9

Issue description

Add 
LaserPointerControllerTestApi controller_test_api_(controller_.get());

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/464956e02f2de3e4ef31eee8951f3df4ffde34a9

commit 464956e02f2de3e4ef31eee8951f3df4ffde34a9
Author: Alex Newcomer <newcomer@chromium.org>
Date: Thu Aug 09 22:45:20 2018

Create the test api for LaserPointerWorksWithRemoteApp

Just add:
LaserPointerControllerTestApi controller_test_api_(controller_.get());

Bug:  872919 
Change-Id: Ie8bd767ba480df9accfd0b47b0e8c2f93fa645c9
Reviewed-on: https://chromium-review.googlesource.com/1170022
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#524}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/464956e02f2de3e4ef31eee8951f3df4ffde34a9/ash/laser/laser_pointer_controller_unittest.cc

Cc: cindyb@chromium.org
Labels: Merge-Without-Approval
Status: Assigned (was: Started)
Audit violation detected on "464956e02f2de3e4ef31eee8951f3df4ffde34a9"

Revision 464956e02f2de3e4ef31eee8951f3df4ffde34a9 was merged to refs/branch-heads/3497 branch with no merge approval from a TPM! 

Please explain why this change was merged to the branch!
 
This was merged because ash_unittests was not compiling.
Please apply applicable OS(s) here so that the corresponding TPM can take a look.
Labels: M-69
Labels: OS-Chrome
cindyb@ was this merge approved?
Status: Fixed (was: Assigned)

Sign in to add a comment