Add link to the respective crrev.com page for merged changes |
|||||
Issue descriptionAffected Version: 2.15.3-4589-ge6e891f4cc What steps will reproduce the problem? 1. Open a merged change. 2. Look for a link to the crrev.com page for that change. What is the expected output? There should be one as it there is in Rietveld. What do you see instead? There is none. Please provide any additional information below. Example of a committed change in Gerrit that doesn't have that link: https://chromium-review.googlesource.com/c/chromium/src/+/1103616 Example of a committed change in Rietveld that does ("Committed" field): https://codereview.chromium.org/2507213002/ One idea is to make the "Cr-Commit-Position" field become that link. Or it could be a separate field as it is on Rietveld.
,
Aug 9
Click on it and you'll see. :) That link currently ends at the very same Gerrit page you were.
,
Aug 9
Ah, my mistake. Are you looking for the link that exists in the header, labeled "Merged as {SHA}"?
,
Aug 9
Yes, that's exactly it! A little harder to find though but solves the initial issue. Thanks. So, now just as a feature suggestion: How about still link-ifying the "Cr-Commit-Position" anyway to make it clearer? IMO it's easier as devs are more used to finding it in the commit message and it would make sense too as crrev.com also accepts commit position values.
,
Aug 9
Seems like a reasonable request, and wouldn't be too difficult! https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#commentlink
,
Aug 9
,
Aug 31
,
Aug 31
,
Oct 31
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kaspern@google.com
, Aug 9