New issue
Advanced search Search tips

Issue 872909 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 782066
Owner:
Closed: Sep 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

Worklet gives useless log on syntax error

Project Member Reported by surma@chromium.org, Aug 9

Issue description

Chrome Version       : 70.0.3516.0 (Official Build) canary (64-bit)
OS Version: OS X 10.13.6


What steps will reproduce the problem?
Call CSS.animationWorklet.addModule() with a file that for example contains
`registerAnimator('nothing', class {);`

What is the expected result?
A description of what went wrong

What happens instead of that?
Uncaught (in promise) DOMException: The user aborted a request.


 
Labels: Needs-Triage-M70
Status: Assigned (was: Unconfirmed)
Labels: -Needs-Triage-M70 Hotlist-Experimental
Labels: -Pri-3 OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Windows Pri-2
Cc: ikilpatrick@chromium.org
Components: -Blink>Animation Blink>Workers
Labels: -Hotlist-Experimental
Owner: nhiroki@chromium.org
Summary: Worklet gives useless log on syntax error (was: AnimationWorklet gives useless log on syntax error)
AFAICT this is an issue that is common to all worklets. The initial modules parsing/executing logic is responsible for this. So assigning to nhiroki@ who can further triage this.


Here is a simple repro showing the same issue for Paint, Audio and Animation Worklets (just run this in devtools console):



function urlFromText(text) {
  const blob = new Blob([text], {type: "text/javascript"});
  return URL.createObjectURL(blob);
}

CSS.paintWorklet.addModule(urlFromText("var var;"));
CSS.animationWorklet.addModule(urlFromText("var var;"));


let context = new AudioContext();
context.audioWorklet.addModule(urlFromText("var var;"))

nhiroki@ This is making any syntax issue that happens inside worklet context very opaque and confusing and surma@ believe this is creating bad DevX for worklets. Is there anyway we can prioritize this fix?

Also, is this a regression?
Cc: japhet@chromium.org panicker@chromium.org
/cc japhet@ and @panicker per Ian's suggestion.
Mergedinto: 782066
Status: Duplicate (was: Assigned)
Sorry for my delayed reply. This issue is the same with issue 782066 that has been blocked by the spec issue. I'll activate the discussion again.

Sign in to add a comment