New issue
Advanced search Search tips

Issue 872907 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 872903

Blocking:
issue 62400
issue 867135



Sign in to add a comment

PDF XFA: Barcode rendering is very slow

Project Member Reported by hnakashima@chromium.org, Aug 9

Issue description

To repro, on an XFA-enabled build where  crbug.com/872903  is fixed:

1. Open the attached imm5257e_debug_add_page.qpdf.
2. Press the Validate button.
Expected: Scrolling through the beautiful barcodes in the newly added page 6 is smooth.
Actual: Scrolling is not smooth, rendering is slow.
 
imm5257e_debug_add_page.qpdf
2.1 MB Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec4b550c74a700e28bbcffea4b5b7711b2e04459

commit ec4b550c74a700e28bbcffea4b5b7711b2e04459
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Aug 16 21:03:38 2018

Roll src/third_party/pdfium 5f4cd74d2693..f956badf3dd2 (3 commits)

https://pdfium.googlesource.com/pdfium.git/+log/5f4cd74d2693..f956badf3dd2


git log 5f4cd74d2693..f956badf3dd2 --date=short --no-merges --format='%ad %ae %s'
2018-08-16 hnakashima@chromium.org Add a way to save a barcode generated bitmap to a .png.
2018-08-16 tsepez@chromium.org Remove more optional args in core/
2018-08-16 hnakashima@chromium.org Optimize rendering of two dimensional barcodes: deduplicate regions.


Created with:
  gclient setdep -r src/third_party/pdfium@f956badf3dd2

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:872907 
TBR=dsinclair@chromium.org

Change-Id: If58ebe0565280b1361422a9ced2f70af30a93c3b
Reviewed-on: https://chromium-review.googlesource.com/1178247
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583809}
[modify] https://crrev.com/ec4b550c74a700e28bbcffea4b5b7711b2e04459/DEPS

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29954f30e4a364614d3d91d110413a3056a9ed82

commit 29954f30e4a364614d3d91d110413a3056a9ed82
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Aug 17 21:46:38 2018

Roll src/third_party/pdfium 1f867bb6e2c7..1b2b76d634ba (4 commits)

https://pdfium.googlesource.com/pdfium.git/+log/1f867bb6e2c7..1b2b76d634ba


git log 1f867bb6e2c7..1b2b76d634ba --date=short --no-merges --format='%ad %ae %s'
2018-08-17 npm@chromium.org Add FPDFText_GetFontInfo
2018-08-17 thestig@chromium.org Remove CFPF_SkiaBufferFont and CFPF_SkiaFileFont.
2018-08-17 tsepez@chromium.org Rename CJS_Return to CJS_Result.
2018-08-17 hnakashima@chromium.org Optimize rendering of 2D barcodes: create Rect only on black regions.


Created with:
  gclient setdep -r src/third_party/pdfium@1b2b76d634ba

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:872907 
TBR=dsinclair@chromium.org

Change-Id: If97634d9c5aefb8b3eb86eef4073e9aa314514d5
Reviewed-on: https://chromium-review.googlesource.com/1180278
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#584204}
[modify] https://crrev.com/29954f30e4a364614d3d91d110413a3056a9ed82/DEPS

Status: Fixed (was: Assigned)
It's good enough that you don't notice the slow scrolling anymore.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc5a4ccc9a0c2008dc7f6fa1788e22c2d64d5e2d

commit fc5a4ccc9a0c2008dc7f6fa1788e22c2d64d5e2d
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Aug 22 16:54:47 2018

Roll src/third_party/pdfium 94822b57c10e..3caad939aead (20 commits)

https://pdfium.googlesource.com/pdfium.git/+log/94822b57c10e..3caad939aead


git log 94822b57c10e..3caad939aead --date=short --no-merges --format='%ad %ae %s'
2018-08-22 thestig@chromium.org Roll tools/clang/ dec27d726..13b165992 (29 commits)
2018-08-22 thestig@chromium.org Roll third_party/depot_tools/ 5484b866d..02d534031 (93 commits; 18 trivial rolls)
2018-08-22 thestig@chromium.org Roll third_party/zlib/ 39b4a6260..dcf1d0f8c (6 commits)
2018-08-22 thestig@chromium.org Roll third_party/binutils/ e146228c2..4110e0919 (2 commits)
2018-08-22 thestig@chromium.org Roll third_party/googletest/src/ ce468a17c..d52663267 (62 commits)
2018-08-21 tsepez@chromium.org Use UnownedPtr in CPDF_VariableText
2018-08-21 tsepez@chromium.org Use UnownedPtr<> to theme provider in cfwl_widgetproperties.h
2018-08-21 tsepez@chromium.org Use UnownedPtr<> in xfa_resolvenode_rs.h
2018-08-21 hnakashima@chromium.org Remove dead code in CBC_CommonBitMatrix.
2018-08-21 tsepez@chromium.org Use UnownedPtr<> in JBIG2_SDDProc.
2018-08-21 tsepez@chromium.org Use UnownedPtr<> in JBig2_GrrdProc.h.
2018-08-21 hnakashima@chromium.org Remove excessive padding above and below PDF417 barcodes.
2018-08-21 tsepez@chromium.org Use UnownedPtr<> in CJBig2_TRDProc.
2018-08-21 tsepez@chromium.org Avoid copying some big vectors in JBIG2_SymbolDict
2018-08-21 thestig@chromium.org Change GetEmbbedObj() to return an Optional<WideString>.
2018-08-21 tsepez@chromium.org Fix lifetime issue in CJBig2_GRDProc::ProgressiveArithDecodeState
2018-08-21 tsepez@chromium.org Allow creation of a MaybeOwned<T> from UnownedPtr<T>.
2018-08-21 hnakashima@chromium.org Optimize rendering of two dimensional barcodes: defer upscale.
2018-08-21 thestig@chromium.org Fix some IWYU issues in xfa/fxfa/.
2018-08-21 hnakashima@chromium.org Fix one-of property JS errors.


Created with:
  gclient setdep -r src/third_party/pdfium@3caad939aead

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:876222 , chromium:872907 , chromium:872899 
TBR=dsinclair@chromium.org

Change-Id: Ia5aa435aa788b862aaf0c474dd646807a687166b
Reviewed-on: https://chromium-review.googlesource.com/1184402
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585095}
[modify] https://crrev.com/fc5a4ccc9a0c2008dc7f6fa1788e22c2d64d5e2d/DEPS

Sign in to add a comment